From: Zhao Yakui <yakui.zhao@intel.com>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alexey Starikovskiy <aystarik@gmail.com>,
linux acpi <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: acpi-test tree on eeepc: EC error message on second resume
Date: Mon, 13 Oct 2008 13:56:36 +0800 [thread overview]
Message-ID: <1223877396.4141.33.camel@yakui_zhao.sh.intel.com> (raw)
In-Reply-To: <48F24EAE.6020108@suse.de>
On Sun, 2008-10-12 at 23:23 +0400, Alexey Starikovskiy wrote:
> +static int ec_wait_ibf0(struct acpi_ec *ec)
> +{
> + unsigned long delay = jiffies +
> msecs_to_jiffies(ACPI_EC_DELAY);
> + while (time_before(jiffies, delay)) {
> + if (wait_event_timeout(ec->wait, ec_check_ibf0(ec),
> + msecs_to_jiffies(1)))
> + return 0;
Please add the bogus timeout check.
best regards.
Yakui
> + }
> + return -ETIME;
> +}
> +
next prev parent reply other threads:[~2008-10-13 1:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 16:57 Alan Jenkins
2008-10-11 17:09 ` Rafael J. Wysocki
2008-10-11 17:12 ` Alan Jenkins
2008-10-11 17:53 ` Rafael J. Wysocki
2008-10-11 18:15 ` Alan Jenkins
2008-10-11 18:39 ` Alexey Starikovskiy
2008-10-11 19:30 ` Rafael J. Wysocki
2008-10-11 19:31 ` Alexey Starikovskiy
2008-10-11 19:40 ` Rafael J. Wysocki
2008-10-11 19:38 ` Alexey Starikovskiy
2008-10-11 20:54 ` Rafael J. Wysocki
2008-10-12 9:13 ` Alan Jenkins
2008-10-12 19:23 ` Alexey Starikovskiy
2008-10-13 5:56 ` Zhao Yakui [this message]
2008-10-13 8:22 ` Alan Jenkins
2008-10-13 16:39 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223877396.4141.33.camel@yakui_zhao.sh.intel.com \
--to=yakui.zhao@intel.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=astarikovskiy@suse.de \
--cc=aystarik@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®