From: David Howells <dhowells@redhat.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: dhowells@redhat.com, Willy Tarreau <willy@meta-x.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Toshiaki Yamane <yamanetoshi@gmail.com>,
Adam Buchbinder <adam.buchbinder@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/panel: Mark local functions as static (fix smatch warnings)
Date: Fri, 15 Feb 2013 10:55:45 +0000 [thread overview]
Message-ID: <12246.1360925745@warthog.procyon.org.uk> (raw)
In-Reply-To: <1360899751-24377-1-git-send-email-peterhuewe@gmx.de>
Peter Huewe <peterhuewe@gmx.de> wrote:
> +static char old_keypad_profile[][4][9] = {
> {"S0", "Left\n", "Left\n", ""},
> {"S1", "Down\n", "Down\n", ""},
> {"S2", "Up\n", "Up\n", ""},
Things like this should likely be const also. There are several here.
> -void panel_lcd_print(char *s)
> +static void panel_lcd_print(char *s)
const char *s maybe?
David
next prev parent reply other threads:[~2013-02-15 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 3:42 Peter Huewe
2013-02-15 10:55 ` David Howells [this message]
2013-02-15 12:47 ` [PATCH v2] staging/panel: Mark local functions/structs static and add const if applicable (fix sparse warnings) Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12246.1360925745@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adam.buchbinder@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=willy@meta-x.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®