From: Johannes Berg <johannes@sipsolutions.net>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
davem@davemloft.net,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] fix WARN() for PPC
Date: Thu, 23 Oct 2008 08:26:33 +0200 [thread overview]
Message-ID: <1224743193.5865.11.camel@johannes.berg> (raw)
In-Reply-To: <48FF8BB9.7050506@goop.org>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Wed, 2008-10-22 at 13:23 -0700, Jeremy Fitzhardinge wrote:
> Arjan van de Ven wrote:
> > From: Arjan van de Ven <arjan@linux.intel.com>
> > Date: Mon, 20 Oct 2008 14:41:03 -0700
> > Subject: [PATCH] fix WARN() for PPC
> >
> > powerpc doesn't use the generic WARN_ON infrastructure.
>
> Hm, why's that now? The generic infrastructure was taken from powerpc,
> and I thought I'd converted it...
The definition of "generic" changed midway. When you did the "generic"
infrastructure, it was written to use traps for both WARN and BUG. But
then somebody didn't like that and added new "generic" infrastructure
(the one Arjan is talking about) which doesn't use traps for WARN but
rather an unlikely() and an actual function call etc. Then Arjan
improved the latter "generic" infrastructure without regard for the
original one.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-10-23 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 21:50 Arjan van de Ven
2008-10-20 23:13 ` Benjamin Herrenschmidt
2008-10-22 20:23 ` Jeremy Fitzhardinge
2008-10-22 20:31 ` Arjan van de Ven
2008-10-23 6:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224743193.5865.11.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=arjan@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®