From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH 6/9] checkpatch: detect multiple bitfield declarations
Date: Thu, 23 Oct 2008 12:06:36 +0100 [thread overview]
Message-ID: <1224759999-21389-7-git-send-email-apw@shadowen.org> (raw)
In-Reply-To: <1224759999-21389-1-git-send-email-apw@shadowen.org>
Detect the colons (:) which make up secondary bitfield declarations
and apply binary colon checks. For example the following is common
idiom:
int foo:1,
bar:1;
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
scripts/checkpatch.pl | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 90f78ef..c73fd44 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -844,11 +844,11 @@ sub annotate_values {
$type = 'V';
$av_pending = 'V';
- } elsif ($cur =~ /^($Ident\s*):/) {
- if ($type eq 'E') {
- $av_pend_colon = 'L';
- } elsif ($type eq 'T') {
+ } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
+ if (defined $2 && $type eq 'C' || $type eq 'T') {
$av_pend_colon = 'B';
+ } elsif ($type eq 'E') {
+ $av_pend_colon = 'L';
}
print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
$type = 'V';
@@ -866,6 +866,10 @@ sub annotate_values {
$type = 'E';
$av_pend_colon = 'O';
+ } elsif ($cur =~/^(,)/) {
+ print "COMMA($1)\n" if ($dbg_values > 1);
+ $type = 'C';
+
} elsif ($cur =~ /^(\?)/o) {
print "QUESTION($1)\n" if ($dbg_values > 1);
$type = 'N';
@@ -881,7 +885,7 @@ sub annotate_values {
}
$av_pend_colon = 'O';
- } elsif ($cur =~ /^(;|\[)/o) {
+ } elsif ($cur =~ /^(\[)/o) {
print "CLOSE($1)\n" if ($dbg_values > 1);
$type = 'N';
--
1.6.0.2.711.gf1ba4
next prev parent reply other threads:[~2008-10-23 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 11:06 [PATCH 0/9] checkpatch: update to versoin 0.25 Andy Whitcroft
2008-10-23 11:06 ` [PATCH 1/9] checkpatch: add checks for in_atomic() Andy Whitcroft
2008-10-23 11:06 ` [PATCH 2/9] checkpatch: comment detection may miss an implied comment on the last hunk Andy Whitcroft
2008-10-23 11:06 ` [PATCH 3/9] checkpatch: widen implied comment detection to allow multiple stars Andy Whitcroft
2008-10-23 11:06 ` [PATCH 4/9] checkpatch: structure member assignments are not complex Andy Whitcroft
2008-10-23 11:06 ` [PATCH 5/9] checkpatch: __weak is an official attribute Andy Whitcroft
2008-10-23 11:06 ` Andy Whitcroft [this message]
2008-10-23 11:06 ` [PATCH 7/9] checkpatch: comment ends inside strings is most likely not an open comment Andy Whitcroft
2008-10-23 11:06 ` [PATCH 8/9] checkpatch: dissallow spaces between stars in pointer types Andy Whitcroft
2008-10-23 11:06 ` [PATCH 9/9] checkpatch: version: 0.25 Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224759999-21389-7-git-send-email-apw@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®