Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress

[Huang Ying <ying.huang@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Wed, 2008-10-29 at 02:34 -0600, Ingo Molnar wrote:
> * Huang Ying <ying.huang@intel.com> wrote:
> 
> > Fix a race condition accessing oops_in_progress.  Which may be 
> > changed on multiple CPU simultaneously, but it is changed via 
> > non-atomic operation ++/--.  This patch changes the definition of 
> > oops_in_process from int to atomic_t, and accessing method to atomic 
> > operations.
> > 
> > 
> > ChangeLog
> > 
> > v2:
> > 
> > - Includes fixes from Andrew Moton.
> > 
> > - Re-based on Matthew Wilcox's new atomic_t patch.
> 
> hm, there are a couple of places now that do atomic_set(,1) - they 
> should be atomic_inc(), correct?

I just translate "oops_in_progress = 1" to
"atomic_set(&oops_in_progress, 1)". I think this is the safest method to
do the translation.

Best Regards,
Huang Ying 


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]