From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <andi@firstfloor.org>, Andi Kleen <ak@linux.intel.com>,
stable <stable@kernel.org>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/6] sysfs: Fix return values for sysdev_store_{ulong,int}
Date: Wed, 29 Oct 2008 15:58:09 -0700 [thread overview]
Message-ID: <1225321092-21933-3-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20081029223824.GB21657@kroah.com>
From: Andi Kleen <andi@firstfloor.org>
SYSFS: Fix return values for sysdev_store_{ulong,int}
Always return the full size instead of the consumed
length of the string in sysdev_store_{ulong,int}
This avoids EINVAL errors in some echo versions.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/sys.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/base/sys.c b/drivers/base/sys.c
index 3ca9c5e..c98c31e 100644
--- a/drivers/base/sys.c
+++ b/drivers/base/sys.c
@@ -488,7 +488,8 @@ ssize_t sysdev_store_ulong(struct sys_device *sysdev,
if (end == buf)
return -EINVAL;
*(unsigned long *)(ea->var) = new;
- return end - buf;
+ /* Always return full write size even if we didn't consume all */
+ return size;
}
EXPORT_SYMBOL_GPL(sysdev_store_ulong);
@@ -511,7 +512,8 @@ ssize_t sysdev_store_int(struct sys_device *sysdev,
if (end == buf || new > INT_MAX || new < INT_MIN)
return -EINVAL;
*(int *)(ea->var) = new;
- return end - buf;
+ /* Always return full write size even if we didn't consume all */
+ return size;
}
EXPORT_SYMBOL_GPL(sysdev_store_int);
--
1.6.0.2
next prev parent reply other threads:[~2008-10-29 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 22:38 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2008-10-29 22:58 ` [PATCH 1/6] Document kernel taint flags properly Greg Kroah-Hartman
2008-10-29 22:58 ` [PATCH 2/6] driver core: drivers/base/sys.c: update comments Greg Kroah-Hartman
2008-10-29 22:58 ` Greg Kroah-Hartman [this message]
2008-10-29 22:58 ` [PATCH 4/6] Update stable tree documentation Greg Kroah-Hartman
2008-10-29 22:58 ` [PATCH 5/6] HOWTO: Sync patch for jp_JP/HOWTO Greg Kroah-Hartman
2008-10-29 22:58 ` [PATCH 6/6] Driver core: fix 'dynamic_debug' cmd line parameter Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225321092-21933-3-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®