From: Jeff Layton <jlayton@redhat.com>
To: smfrench@gmail.com
Cc: smfrench@austin.rr.com, linux-cifs-client@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] cifs: fix oopses and mem corruption with concurrent mount/umount (try #4)
Date: Thu, 30 Oct 2008 11:16:29 -0400 [thread overview]
Message-ID: <1225379793-23283-1-git-send-email-jlayton@redhat.com> (raw)
This patchset is intended to fix the oopses, memory corruption and mount
failures when using the reproducer detailed here:
https://bugzilla.samba.org/show_bug.cgi?id=5720
This is the fourth attempt at this. Since the third attempt, Steve
French has committed the patch to handle the server->tsk pointer more
atomically so that patch is ommitted here. While that patch helps ensure
that the shutdown of the demux thread happens cleanly, there are still
other races.
Andrew Morton has also taken the patch to clean up the server protocol
handling for -mm. I've included this patch in the set since Steve has
not yet taken it, and I've had to modify it slightly for changes that
have gone into Steve's tree.
This patchset is based on Steve French's cifs-2.6 git tree and should
apply cleanly to its current state.
The main differences in this patchset are that it fixes some bugs in
list handling in the earlier patchsets. It also reenables the sharing
of tree connects. With this, any structures that were previously
shared should remain so (no loss of functionality).
There's still some remaining cleanup work that can be done here. The
cifs_mount code could stand to be broken up into smaller functions.
cifs_debug_data_proc_show could also stand to be reorganized to better
reflect the heirarchy of server->session->tcon. Those changes are
probably more suitable in follow-on patches. I'd like to know whether
these are acceptible before I spend time working on them.
I've been able to run the reproducer in the above BZ overnight on this
patchset. Without it, it usually crashes within a few minutes.
Jeff Layton (4):
cifs: clean up server protocol handling for TCP_Server_Info
cifs: disable sharing session and tcon and add new TCP sharing code
cifs: reinstate sharing of SMB sessions
cifs: reinstate sharing of tree connections
fs/cifs/cifs_debug.c | 286 +++++++++++++++++++---------------
fs/cifs/cifsfs.c | 33 +++--
fs/cifs/cifsglob.h | 28 ++--
fs/cifs/cifssmb.c | 54 +------
fs/cifs/connect.c | 426 +++++++++++++++++++++++++-------------------------
fs/cifs/misc.c | 93 +++++------
6 files changed, 456 insertions(+), 464 deletions(-)
next reply other threads:[~2008-10-30 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 15:16 Jeff Layton [this message]
2008-10-30 15:16 ` [PATCH 1/4] cifs: clean up server protocol handling for TCP_Server_Info Jeff Layton
2008-10-30 15:16 ` [PATCH 2/4] cifs: disable sharing session and tcon and add new TCP sharing code Jeff Layton
2008-10-30 15:16 ` [PATCH 3/4] cifs: reinstate sharing of SMB sessions Jeff Layton
2008-10-30 15:16 ` [PATCH 4/4] cifs: reinstate sharing of tree connections Jeff Layton
[not found] ` <524f69650810301025t3f3b7fb6t10d96b6567a67715@mail.gmail.com>
2008-10-30 17:26 ` Fwd: [PATCH 0/4] cifs: fix oopses and mem corruption with concurrent mount/umount (try #4) Steve French
2008-10-30 17:42 ` Jeff Layton
2008-10-30 17:51 ` Steve French
2008-10-30 18:01 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225379793-23283-1-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@austin.rr.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®