From: Nate Case <ncase@xes-inc.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc-ds1307: Reset bogus register values on m41t00
Date: Thu, 30 Oct 2008 16:34:46 -0500 [thread overview]
Message-ID: <1225402486.27415.177.camel@localhost.localdomain> (raw)
In-Reply-To: <1225398691.27415.170.camel@localhost.localdomain>
On Thu, 2008-10-30 at 15:31 -0500, Nate Case wrote:
> I'll go ahead and re-spin the patch.
After thinking about this more, I'm not sure it's right to do anything
more than the "remove legacy probe checks" patch already does. Can you
think of any harm in having the oscillator running with bogus register
values? Calls to get_time() will return -EINVAL, but that seems to be
the norm for any "bad time" condition. It makes me think that resetting
to a sane time is putting more policy than desired in the driver.
--
Nate Case <ncase@xes-inc.com>
next prev parent reply other threads:[~2008-10-30 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 17:29 Nate Case
2008-10-30 8:16 ` David Brownell
2008-10-30 15:05 ` Nate Case
2008-10-30 17:06 ` David Brownell
2008-10-30 20:31 ` Nate Case
2008-10-30 21:34 ` Nate Case [this message]
2008-10-30 22:11 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225402486.27415.177.camel@localhost.localdomain \
--to=ncase@xes-inc.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome