From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbYJaWBQ (ORCPT ); Fri, 31 Oct 2008 18:01:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752519AbYJaWBA (ORCPT ); Fri, 31 Oct 2008 18:01:00 -0400 Received: from accolon.hansenpartnership.com ([76.243.235.52]:37885 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbYJaWA7 (ORCPT ); Fri, 31 Oct 2008 18:00:59 -0400 Subject: Re: [PATCH] fix ACPI induced voyager compile failure From: James Bottomley To: Ingo Molnar Cc: Thomas Gleixner , linux-kernel In-Reply-To: <20081030221645.GL30303@elte.hu> References: <1225400518.19324.11.camel@localhost.localdomain> <20081030215819.GI30303@elte.hu> <1225404299.19324.47.camel@localhost.localdomain> <20081030221645.GL30303@elte.hu> Content-Type: text/plain Date: Fri, 31 Oct 2008 12:42:02 -0500 Message-Id: <1225474922.3264.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2008-10-30 at 23:16 +0100, Ingo Molnar wrote: > * James Bottomley wrote: > > > On Thu, 2008-10-30 at 22:58 +0100, Ingo Molnar wrote: > > > * James Bottomley wrote: > > > > > > > >From c339b7cdc39399855ec07dfbff67304f9c7fa49a Mon Sep 17 00:00:00 2001 > > > > From: James Bottomley > > > > Date: Wed, 29 Oct 2008 10:58:13 -0500 > > > > Subject: [VOYAGER] x86: don't pull asm/acpi.h into fixmap_32.h > > > > > > > > If it's not needed it causes compile failures. > > > > > > > > Signed-off-by: James Bottomley > > > > --- > > > > arch/x86/include/asm/fixmap_32.h | 2 ++ > > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/x86/include/asm/fixmap_32.h b/arch/x86/include/asm/fixmap_32.h > > > > index 09f29ab..c3302ee 100644 > > > > --- a/arch/x86/include/asm/fixmap_32.h > > > > +++ b/arch/x86/include/asm/fixmap_32.h > > > > @@ -25,7 +25,9 @@ extern unsigned long __FIXADDR_TOP; > > > > > > > > #ifndef __ASSEMBLY__ > > > > #include > > > > +#ifdef CONFIG_ACPI > > > > #include > > > > +#endif > > > > > > hm, that's quite ugly - such headers are supposed to be safe even if > > > CONFIG_APIC is not turned on. > > > > > > What kind of compiler failures are you getting, could you send the > > > .config that triggers it? I'm curious what the real cause of the build > > > failure is - the #ifdef you are adding seems to fix a symptom, not a > > > real bug - and maybe we can do a better fix. > > > > It's the problem of voyager wanting its own definition of > > phys_cpu_present_map. acpi.h pulls in mpspec.h which contaminates the > > voyager_smp.c build. > > i guess voyager could use physid_mask_t just fine? > > physid_mask_t is MAX_APICS derived - but it should work out fine > because AFAICS voyager has a maximum of 4 cpus (but definitely less > than say 32), while MAX_APICS never goes below 256. Voyager has a max of 32 actually. The CPU numbering is also fixed and identifies the processor position (for FRU replacement), so the physical map is what we use throughout the code. The problem with the definition is that it makes a rather pointless distinction between physical and logical map types ... so there'd be a lot of code churn. It would be really nice if physmask_t and cpumask_t could become the same type ... then we could do all this and no-one would notice. James