From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbdI2NAh (ORCPT ); Fri, 29 Sep 2017 09:00:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50152 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751813AbdI2NAe (ORCPT ); Fri, 29 Sep 2017 09:00:34 -0400 Subject: Re: [PATCH v8 6/6] powerpc/fadump: use the new parse_args callback arguments To: Michal Suchanek , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jonathan Corbet , Jessica Yu , Rusty Russell , Jason Baron , Mahesh Salgaonkar , Daniel Axtens , Nicholas Piggin , Andrew Morton , Michael Neuling , Thiago Jung Bauermann , "Sylvain 'ythier' Hitier" , David Howells , Ingo Molnar , Kees Cook , Thomas Gleixner , "Steven Rostedt," , Michal Hocko , Laura Abbott , Tejun Heo , Tom Lendacky , Viresh Kumar , Lokesh Vutla , Baoquan He , Ilya Matveychikov , linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <4fabdf584ad18d6aae61e331f783a5020567f634.1505231820.git.msuchanek@suse.de> From: Hari Bathini Date: Fri, 29 Sep 2017 18:30:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4fabdf584ad18d6aae61e331f783a5020567f634.1505231820.git.msuchanek@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-MML: disable x-cbid: 17092913-0008-0000-0000-00000158F6AC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17092913-0009-0000-0000-0000098EA139 Message-Id: <12256349-cdac-8e66-699f-095873ed2809@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-29_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709290186 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case, someone wishes for a changelog: With fadump_rework_cmdline_params() function, parse_args() callback function, taking new arguments - current & next, use them to process 'fadump_extra_args=' parmeter, in enforcing the parameters passed through it for fadump kernel. On Tuesday 12 September 2017 09:31 PM, Michal Suchanek wrote: > Signed-off-by: Michal Suchanek > --- > arch/powerpc/kernel/fadump.c | 47 ++++++++++++-------------------------------- > 1 file changed, 13 insertions(+), 34 deletions(-) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 8778e1cc0380..1678d99ea835 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -481,33 +481,19 @@ struct param_info { > }; > > static void __init fadump_update_params(struct param_info *param_info, > - char *param, char *val) > + char *param, char *val, > + char *currant, char *next) > { > - ptrdiff_t param_offset = param - param_info->tmp_cmdline; > + ptrdiff_t param_offset = currant - param_info->tmp_cmdline; > size_t vallen = val ? strlen(val) : 0; > char *tgt = param_info->cmdline + param_offset > - param_info->shortening; > - int shortening = 0; > - int quoted = 0; > + int shortening = ((next - 1) - (currant)) > + - (FADUMP_EXTRA_ARGS_LEN + 1 + vallen); > > if (!val) > return; > > - /* leading '"' removed from parameter */ > - if ((param > param_info->tmp_cmdline) && *(param - 1) == '"') { > - quoted = 1; > - shortening += 1; > - tgt--; > - } > - > - /* next_arg removes one leading and one trailing '"' */ > - if ((*(tgt + FADUMP_EXTRA_ARGS_LEN + 1 + vallen + shortening) == '"') && > - (quoted || (*(tgt + FADUMP_EXTRA_ARGS_LEN + 1) == '"'))) { > - shortening += 1; > - if (!quoted) > - shortening += 1; > - } > - > /* remove one leading and one trailing quote if both are present */ > if ((val[0] == '"') && (val[vallen - 1] == '"')) { > shortening += 2; > @@ -515,22 +501,15 @@ static void __init fadump_update_params(struct param_info *param_info, > val++; > } > > - /* some characters were removed - move the trailing part of cmdline */ > - if (shortening) { > - char *src; > + strncpy(tgt, FADUMP_EXTRA_ARGS_PARAM, FADUMP_EXTRA_ARGS_LEN); > + tgt += FADUMP_EXTRA_ARGS_LEN; > + *tgt++ = ' '; > + strncpy(tgt, val, vallen); > + tgt += vallen; > > - strncpy(tgt, FADUMP_EXTRA_ARGS_PARAM, FADUMP_EXTRA_ARGS_LEN); > - tgt += FADUMP_EXTRA_ARGS_LEN; > - *tgt++ = ' '; > - > - strncpy(tgt, val, vallen); > - tgt += vallen; > - > - src = tgt + shortening; > + if (shortening) { > + char *src = tgt + shortening; > memmove(tgt, src, strlen(src) + 1); > - } else { > - /* remove the '=' */ > - *(tgt + FADUMP_EXTRA_ARGS_LEN) = ' '; > } > > param_info->shortening += shortening; > @@ -550,7 +529,7 @@ static int __init fadump_rework_cmdline_params(char *param, char *val, > strlen(FADUMP_EXTRA_ARGS_PARAM) - 1)) > return 0; > > - fadump_update_params(param_info, param, val); > + fadump_update_params(param_info, param, val, currant, next); > > return 0; > } Thanks Hari