From: Matt Fleming <mjf@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@elte.hu, venkatesh.pallipadi@intel.com,
Matt Fleming <mjf@gentoo.org>
Subject: [PATCH 3/3] HPET: Read from HPET_Tn_CMP() not HPET_T0_CMP
Date: Sun, 2 Nov 2008 16:04:20 +0000 [thread overview]
Message-ID: <1225641860-6120-3-git-send-email-mjf@gentoo.org> (raw)
In-Reply-To: <1225641860-6120-2-git-send-email-mjf@gentoo.org>
In hpet_next_event() we check that the value we just wrote to
HPET_Tn_CMP(timer) has reached the chip. Currently, we're checking that
the value we wrote to HPET_Tn_CMP(timer) is in HPET_T0_CMP, which, if
timer is anything other than timer 0, is likely to fail.
Signed-off-by: Matt Fleming <mjf@gentoo.org>
---
arch/x86/kernel/hpet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index c28fff2..76feb2e 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -322,7 +322,7 @@ static int hpet_next_event(unsigned long delta,
* what we wrote hit the chip before we compare it to the
* counter.
*/
- WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt);
+ WARN_ON_ONCE((u32)hpet_readl(HPET_Tn_CMP(timer)) != cnt);
return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0;
}
--
1.5.6.4
next prev parent reply other threads:[~2008-11-02 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 16:04 [PATCH 1/3] HPET: Convert WARN_ON to WARN_ON_ONCE Matt Fleming
2008-11-02 16:04 ` [PATCH 2/3] HPET: Enter hpet_interrupt_handler with interrupts disabled Matt Fleming
2008-11-02 16:04 ` Matt Fleming [this message]
2008-11-09 10:33 ` [PATCH 3/3] HPET: Read from HPET_Tn_CMP() not HPET_T0_CMP Matt Fleming
2008-11-10 16:40 ` Thomas Gleixner
2008-11-02 21:35 ` [PATCH 2/3] HPET: Enter hpet_interrupt_handler with interrupts disabled Will Newton
2008-11-02 22:23 ` Matt Fleming
2008-11-10 16:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225641860-6120-3-git-send-email-mjf@gentoo.org \
--to=mjf@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®