From: Frank Mayhar <fmayhar@google.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
adobriyan@gmail.com, Doug Chapman <doug.chapman@hp.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock
Date: Tue, 11 Nov 2008 09:10:23 -0800 [thread overview]
Message-ID: <1226423423.4444.8.camel@bobble.smo.corp.google.com> (raw)
In-Reply-To: <20081111103532.GA8869@elte.hu>
On Tue, 2008-11-11 at 11:35 +0100, Ingo Molnar wrote:
> * Oleg Nesterov <oleg@redhat.com> wrote:
> > The patch is ugly, but I don't see the better fix for now. Needs the
> > review from Peter/Ingo.
> this is indeed too ugly, and if we do it we'll get both this ugliness
> and the CPU loop upstream forever. Frank, if you dont have time to fix
> this code, then i guess the best thing is to do the full revert that
> Peter sent.
Well, at the moment I'm up to my armpits in alligators. That said,
we're going to have to pull in this code regardless, ugliness and all,
since we're guaranteed to run into the soft lockup bug otherwise. This
means that I'll have strong incentive to come back and readdress the fix
to remove the ugliness and address Peter's concerns. I have no idea
when that will be, however.
--
Frank Mayhar <fmayhar@google.com>
Google, Inc.
next prev parent reply other threads:[~2008-11-11 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 14:39 Oleg Nesterov
2008-11-11 10:35 ` Ingo Molnar
2008-11-11 12:58 ` Oleg Nesterov
2008-11-11 17:10 ` Frank Mayhar [this message]
2008-11-11 17:16 ` Ingo Molnar
2008-11-11 17:28 ` Frank Mayhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226423423.4444.8.camel@bobble.smo.corp.google.com \
--to=fmayhar@google.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=doug.chapman@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®