From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Jens Axboe <jens.axboe@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
albcamus@gmail.com, pjones@redhat.com, alex.shi@intel.com
Subject: Re: system fails to boot
Date: Fri, 14 Nov 2008 15:22:06 +0800 [thread overview]
Message-ID: <1226647326.2866.87.camel@ymzhang> (raw)
In-Reply-To: <491D1932.10808@kernel.org>
On Fri, 2008-11-14 at 15:22 +0900, Tejun Heo wrote:
> Alexey Dobriyan wrote:
> >> Would you like to accept the kernel patch into your testing tree? Pls. do CC to me when replying
> >> as I couldn't subscribe LKML emails now.
> >>
> >> ---
> >>
> >> --- linux-2.6.28-rc4/block/genhd.c 2008-11-11 08:37:24.000000000 +0800
> >> +++ linux-2.6.28-rc4_label/block/genhd.c 2008-11-13 04:05:35.000000000 +0800
> >> @@ -1028,6 +1028,7 @@ static int __init proc_genhd_init(void)
> >> {
> >> proc_create("diskstats", 0, NULL, &proc_diskstats_operations);
> >> proc_create("partitions", 0, NULL, &proc_partitions_operations);
> >> + register_blkdev(BLOCK_EXT_MAJOR, "blkext");
> >> return 0;
> >> }
> >> module_init(proc_genhd_init);
> >
> > It's procfs-specific init, what's up?
>
> Ah... right, better to move it to genhd_device_init(). Thanks.
Thanks. I thought nash reads /proc/devices so just added there.
Below patch moves it to genhd_device_init. I tested it on my Nehalem machine.
---
--- linux-2.6.28-rc4/block/genhd.c 2008-11-14 17:20:29.000000000 +0800
+++ linux-2.6.28-rc4_boot/block/genhd.c 2008-11-14 23:11:43.000000000 +0800
@@ -768,6 +768,8 @@ static int __init genhd_device_init(void
bdev_map = kobj_map_init(base_probe, &block_class_lock);
blk_dev_init();
+ register_blkdev(BLOCK_EXT_MAJOR, "blkext");
+
#ifndef CONFIG_SYSFS_DEPRECATED
/* create top-level block dir */
block_depr = kobject_create_and_add("block", NULL);
next prev parent reply other threads:[~2008-11-14 7:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 5:16 Zhang, Yanmin
2008-11-14 5:26 ` Tejun Heo
2008-11-14 7:16 ` Jens Axboe
2008-11-14 6:18 ` Alexey Dobriyan
2008-11-14 6:22 ` Tejun Heo
2008-11-14 7:22 ` Zhang, Yanmin [this message]
2008-11-14 6:29 ` Zhang, Yanmin
2008-11-17 8:19 ` Zhang, Yanmin
2008-11-21 17:26 ` Jike Song
2008-11-24 5:52 ` Zhang, Yanmin
2008-11-24 6:40 ` Jike Song
2008-11-24 6:57 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226647326.2866.87.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=albcamus@gmail.com \
--cc=alex.shi@intel.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome