mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: dbrownell@users.sourceforge.net
Cc: Mark Brown <broonie@sirena.org.uk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.28-rc5] regulator: enable/disable refcounting
Date: Mon, 17 Nov 2008 16:46:30 +0000	[thread overview]
Message-ID: <1226940390.585.4.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <200811170821.47582.david-b@pacbell.net>

On Mon, 2008-11-17 at 08:21 -0800, David Brownell wrote:
> On Monday 17 November 2008, Mark Brown wrote:
> > On Sun, Nov 16, 2008 at 11:44:46AM -0800, David Brownell wrote:
> > 
> > > +	mutex_lock(&rdev->mutex);
> > > +	if (regulator->enabled == 1) {
> > > +		ret = _regulator_disable(rdev);
> > > +		if (ret == 0)
> > > +			regulator->uA_load = 0;
> > 
> > Why clear the load here?  I'd expect to be able to enable and disable
> > the regulator while preserving the configuration.
> 
> That clear was in the original code.  Didn't make much sense
> to me either, but I was just caring it forward...
> 

Hmm, this looks like a bug - I'll fix in a subsequent patch.

Will have time to look over the rest later tonight.

Thanks

Liam 


  reply	other threads:[~2008-11-17 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 19:44 David Brownell
2008-11-17 15:16 ` Mark Brown
2008-11-17 16:21   ` David Brownell
2008-11-17 16:46     ` Liam Girdwood [this message]
2008-11-19 21:26 ` Liam Girdwood
2008-11-19 22:12   ` David Brownell
2008-11-20 21:58     ` Liam Girdwood
2008-11-20 22:05       ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226940390.585.4.camel@vega.slimlogic.co.uk \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@sirena.org.uk \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®