From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EFC44DB68 for ; Wed, 6 May 2026 13:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778074092; cv=none; b=fstBG77L2KGG/tPghDhKvwoVddPhyPTj3nbMcQ4CNk9PrtT2Ha5hB8sm6bmdcdpzG9eZaGFBSUcBZrFP5I83qP3lW00cIO/BMHie+yhLTlp3146SwxkIX9r4Ex6WpU3I12Slwz2z0Ze2bj/zncct5W37+7809tNy4xLIF+/Lld0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778074092; c=relaxed/simple; bh=1YW1t4xBkQhP9j4ZJX7CPHZAQiCKQvy1TD609Z+biLQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gtH8oD8iw45i2O0eXvE5gnRwXkHQaFpv1YZQe1UXwkCFhFa9JdSkQrkJ0cuqnLQXcwaWPwMnds/t9D03KCjz09PphsZHNGWCZqWe/xJA/tjz0N/3z9kgI/JV2YKZBW12gd4rAS0NQHTW4L+v0n8Uvam2wheX7bcTOG7ev9inSw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kPVlwLV/; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kPVlwLV/" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-362e50b4641so3730355a91.0 for ; Wed, 06 May 2026 06:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778074090; x=1778678890; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=3uS1a9bcJxdnsN4Cgf1syG4AWcpUPrEuuLJmo6Jj7Dw=; b=kPVlwLV/Rb6P0rCO4NlhuDo74LCjqQ3JJFdzVa7Mfw64KvD9iZyKz/d9ifMYrLgt3w hSImknI6kMxF3TLosKMtKTUeiOGR3dyxnoBgKwAnW2bHFH6B/tuaXbeVbI+Gw/37gcl+ giPrAcJn7++IkvYuT05WnUa/EKBshOnPgS762fztwZI2rBHAYCveMK9LmDItLtdH/AUA hW9YRKNzZQ7PwrwwlKbG6uZtzPBpZRFVuNAxXIOKyr8d+AS6ZwXiPLddE0kLJlaIvcwK QqSdhHaJcOBH9QwSIp4PM5IavB37nVyW8TttX70hhhU3rm5rNAAZoBBUz6vOt8rJyzSO PQOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778074090; x=1778678890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3uS1a9bcJxdnsN4Cgf1syG4AWcpUPrEuuLJmo6Jj7Dw=; b=ij1FP7SpmJgV5SFUSfa1SkM42QkcWpZ5+ykYPAp9vsgeP6jFKyJ2ZK8BuEkIgiuULi pGOw+oCmAmgX9jGs6WgUO0WjeqS6wqMMlZUeFk1M0CHZoMBQ65o8w8pcWpLmuzuNMKBN NCwz+At8UFlUBsrkxorYboHzFNjKq2NXdcolHxIF5clyOUMfSd0iqi023pBtII1HySIc Eklsk5Fbndmw+ieIH8AmEIsA5zwTS4N7k2Gus7+eD6e19leJ+2S6+H55/rbZ5m8UlrVn tRl72nan58Rr/HHi2t3aeOFLc/nugW9v6AHijM2a3eTPyqcDdjorcYh1aqnahn07Wkwz P4Eg== X-Forwarded-Encrypted: i=1; AFNElJ8ISenWnS8B8d0pTR1siNRBT/xef4f6ujvvzLC+0MAVtIkr4sDji8wqwws2O84pg+TxSa81kRYgmFS0ops=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9RfDZWROmAXjIZpXE+pOMbqq96QF8Cp6xEpMUW6oBl7FoCHP4 vvl9aAkcaVIxA1lWi2TciFBNsxCbL+iQ14F9dZqWMcAauPiJjDFThQr7 X-Gm-Gg: AeBDietPFbW2LtoJX3krbkTBBD7r2h1s1o/tMaP+GdFsK8IE/Nw8BfWov40ZSi7SCJF RHBAj9fcCbyRFsWqiwJxMtPcrIyJoEM7kd9cGAAFbVP+wVCWyI/fCKZDGb50PmHXvdwWmN40GWa +j171gJpgtLnKkbO3/EYKaU1G4lafQPnIAeojXJ+dfxAcTlt1uDeVYKVkIpcLsGiaq+Z+k7SXXj 7nvhF2NzHyflRTNqvNV9qpXpJXaH3gb9zrCpabPDhcdQXt4Z9qKz+0nVVb5QmDBws4AvVyT5zwC 3Wgh9sPXabtEy4gxrc8rsRt6x51A0HRa+11SGvSDspXFn8AvwIz4fWoybZ5P1yMoubg/pnMahHR l3bT77+do8Ce2W4zvlkgJ2F6nM/ztQGDEBDbtW32069ChK6FMU8aL2T7eG3I75C48Qbu5ZsjWjm 5mGQDoby/rtI90Eb4fGTCC8NhzH9Mnn7Gjy7sThxNXDozKgyo= X-Received: by 2002:a17:90b:264e:b0:365:a968:99ce with SMTP id 98e67ed59e1d1-365ac79e52dmr3411738a91.24.1778074089592; Wed, 06 May 2026 06:28:09 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b4f75f25sm2593699a91.10.2026.05.06.06.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 06:28:08 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 6 May 2026 06:28:07 -0700 From: Guenter Roeck To: Bartosz Golaszewski Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH v3] watchdog: convert the Kconfig dependency on OF_GPIO to OF Message-ID: <1226bbb6-0b89-4a0a-895d-99d4b39d31d3@roeck-us.net> References: <20260506081600.4921-1-bartosz.golaszewski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506081600.4921-1-bartosz.golaszewski@oss.qualcomm.com> On Wed, May 06, 2026 at 10:16:00AM +0200, Bartosz Golaszewski wrote: > OF_GPIO is selected automatically on all OF systems. Any symbols it > controls also provide stubs so there's really no reason to select it > explicitly. We could simply remove the dependency but in order to avoid > a new symbol popping up for everyone in make config - just convert it to > requiring CONFIG_OF. > > Reviewed-by: Guenter Roeck > Signed-off-by: Bartosz Golaszewski Applied to my watchdog-next branch after resolving conflicts. Dependencis are now depends on GPIOLIB && (ACPI || OF) Thanks, Guenter > --- > Changes in v3: > - Send the watchdog patch separately so that it can be picked up for v7.2 > - Link to v2: https://patch.msgid.link/20260316-gpio-of-kconfig-v2-0-de2f4b00a0e4@oss.qualcomm.com > > Changes in v2: > - Make gpio-watchdog depend on OF && GPIOLIB > - Drop picked up patches > - Link to v1: https://patch.msgid.link/20260304-gpio-of-kconfig-v1-0-d597916e79e7@oss.qualcomm.com > > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index dc78729ba2a5..ab1d5d6df5f3 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -250,7 +250,7 @@ config DA9062_WATCHDOG > > config GPIO_WATCHDOG > tristate "Watchdog device controlled through GPIO-line" > - depends on OF_GPIO > + depends on OF && GPIOLIB > select WATCHDOG_CORE > help > If you say yes here you get support for watchdog device