From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Bough Chen <haibo.chen@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "brgl@bgdev.pl" <brgl@bgdev.pl>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base
Date: Mon, 21 Aug 2023 09:44:18 +0200 [thread overview]
Message-ID: <12270129.O9o76ZdvQC@steina-w> (raw)
In-Reply-To: <CACRpkdZ-2Lyk_c8EJfS=YHK81wt2RAWnZAg+vxvZZijYFwmDDA@mail.gmail.com>
Hi Linus,
Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij:
> On Mon, Aug 21, 2023 at 4:47 AM Bough Chen <haibo.chen@nxp.com> wrote:> > Hi
Linus and Bartosz,
> >
> > For this patch, still not in the main trunk (Linux 6.5-rc7) and
> > linux-next(next-20230818). Can you help apply or any comment?
>
> As pointed out by Bartosz you cannot just mechanically switch the base
> to -1.
>
> You also need to convince us that this doesn't break any systems, and if
> it does, fix them so they don't break before submitting this patch.
I think it's hard to tell if something breaks, this driver is used in a lot of
boards. AFAIR some people are relying on the assumption of fixed order. Using
dynamic allocation this not ensured. A possible fix is to use aliases [1].
Best regards,
Alexander
[1] https://lore.kernel.org/lkml/20230215092421.143199-1-alexander.stein@ew.tq-group.com/T/#u
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2023-08-21 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 8:59 [PATCH 1/2] gpio: vf610: " haibo.chen
2023-05-06 8:59 ` [PATCH 2/2] gpio: mxc: " haibo.chen
2023-05-06 13:06 ` Linus Walleij
2023-08-21 2:47 ` Bough Chen
2023-08-21 7:25 ` Linus Walleij
2023-08-21 7:44 ` Alexander Stein [this message]
2023-08-21 10:21 ` Linus Walleij
2023-08-21 12:17 ` Bartosz Golaszewski
2023-08-28 13:56 ` Ahmad Fatoum
2023-05-26 13:12 ` Bartosz Golaszewski
2023-05-06 13:04 ` [PATCH 1/2] gpio: vf610: " Linus Walleij
2023-08-21 2:47 ` Bough Chen
2023-08-22 9:39 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12270129.O9o76ZdvQC@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=haibo.chen@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®