mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	sfr@canb.auug.org.au
Subject: Re: pull request: wireless-2.6 2008-11-18
Date: Wed, 19 Nov 2008 02:33:38 +0100	[thread overview]
Message-ID: <1227058418.4014.99.camel@johannes.berg> (raw)
In-Reply-To: <20081119000719.GA19756@tuxdriver.com> (sfid-20081119_014629_475391_D51592F4)

> and a final one fixes some mysterious DMA alignment problems
> that have been plaguing iwlwifi for some time.


> The following changes since commit 5f9021cfdc3524a4c5e3d7ae2d049eb7adcd6776:
>   Johannes Berg (1):
>         rtnetlink: propagate error from dev_change_flags in do_setlink()

heh.

>      iwlagn: fix RX skb alignment

So Luis pointed out a bug in that, it might be useful to squish in this
patch: http://marc.info/?l=linux-wireless&m=122705425425763&w=2

(also below for reference)

But we can also just add it on top, whichever way you prefer.

johannes
---
 drivers/net/wireless/iwlwifi/iwl-agn.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- everything.orig/drivers/net/wireless/iwlwifi/iwl-agn.c	2008-11-19 01:16:12.000000000 +0100
+++ everything/drivers/net/wireless/iwlwifi/iwl-agn.c	2008-11-19 01:19:13.000000000 +0100
@@ -1229,9 +1229,11 @@ void iwl_rx_handle(struct iwl_priv *priv
 
 		rxq->queue[i] = NULL;
 
-		pci_dma_sync_single_for_cpu(priv->pci_dev, rxb->aligned_dma_addr,
-					    priv->hw_params.rx_buf_size,
-					    PCI_DMA_FROMDEVICE);
+		dma_sync_single_range_for_cpu(
+				&priv->pci_dev->dev, rxb->real_dma_addr,
+				rxb->aligned_dma_addr - rxb->real_dma_addr,
+				priv->hw_params.rx_buf_size,
+				PCI_DMA_FROMDEVICE);
 		pkt = (struct iwl_rx_packet *)rxb->skb->data;
 
 		/* Reclaim a command buffer only if this packet is a response



  reply	other threads:[~2008-11-19  1:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19  0:07 John W. Linville
2008-11-19  1:33 ` Johannes Berg [this message]
2008-11-19  1:54   ` John W. Linville
2008-11-19  6:46 ` Tomas Winkler
2008-11-19  9:34   ` Tomas Winkler
2008-11-19 14:39     ` John W. Linville
2008-11-19 16:51       ` Tomas Winkler
2008-11-19 18:53         ` John W. Linville
2008-11-19 21:55           ` Tomas Winkler
2008-11-20  0:37             ` John W. Linville
2008-11-20  9:27               ` Tomas Winkler
2008-11-24  3:34       ` Zhu Yi
2008-11-24  3:50         ` Marcel Holtmann
2008-11-24  6:33           ` Zhu Yi
2008-11-24  8:33             ` Marcel Holtmann
2008-11-20 12:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227058418.4014.99.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®