mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Ribeiro <drwyrm@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
	spi-devel-general@lists.sourceforge.net,
	Stefan Schmidt <stefan@openmoko.org>,
	eric.y.miao@gmail.com, linux-kernel@vger.kernel.org,
	sameo@openedhand.com, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [spi-devel-general] [patch 05/14] mfd: PCAP2 driver
Date: Sun, 23 Nov 2008 05:06:02 -0200	[thread overview]
Message-ID: <1227423962.3148.74.camel@brutus> (raw)
In-Reply-To: <200811222059.59806.david-b@pacbell.net>

Em Sáb, 2008-11-22 às 20:59 -0800, David Brownell escreveu:
> > I tried spi_write_then_read before, but it didn't work. I supposed it
> > was because it was doing 2 transfers as the second transfer rx_buf
> > always came zeroed.
> 
> You may have been using it wrong.  Also, verify against
> current kernels ... there have been bugfixes to pxa2xx_spi.
> 
> > I see that commit 
> > f9b90e39cbc5c4d6ef60022fd1f25d541df0aad1 changed it to do a single
> > transfer, so i will try it again.
> 
> Unless it needs the full duplex capability of SPI, then
> you should be able to make write_then_read work ... on
> the other hand, if you do need full duplex, then you
> should address the DMA.  (And byteswapping, either way.)

Well, i guess it is full duplex, as i set spi_transfer.len to 4 bytes,
write 4 bytes _and_ read 4 bytes to/from the chip.

I'm looking at write_then_read and if I read it correctly, it sends n_tx
bytes of data plus n_rx bytes of nothing, and discards n_tx bytes from
the start of the receive buffer considering only n_rx bytes from the end
of the receive buffer. This is not what i want.

Can you be more descriptive on "address the DMA"? Im not familiar on
what is the issue here.

I will take care of byte swapping for the next patch.

-- 
Daniel Ribeiro


  reply	other threads:[~2008-11-23  7:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081121160403.073751031@dodger.lab.datenfreihafen.org>
2008-11-21 16:04 ` stefan
2008-11-22  5:25   ` [spi-devel-general] " David Brownell
2008-11-22 14:01     ` Eric Miao
2008-11-22 15:54       ` Daniel Ribeiro
2008-11-22 19:08         ` David Brownell
2008-11-22 23:29           ` Stefan Schmidt
2008-11-22 17:12     ` Daniel Ribeiro
2008-11-22 19:19       ` David Brownell
2008-11-22 23:33         ` Stefan Schmidt
2008-11-22 23:58           ` David Brownell
2008-11-23  0:33             ` Stefan Schmidt
2008-11-23  2:19               ` David Brownell
2008-11-23  3:38                 ` Daniel Ribeiro
2008-11-23  4:59                   ` David Brownell
2008-11-23  7:06                     ` Daniel Ribeiro [this message]
2008-11-23  8:26                       ` David Brownell
2008-11-21 16:04 ` [patch 08/14] input: PCAP2 based touchscreen driver stefan
2008-11-21 17:05   ` Dmitry Torokhov
2008-11-22  0:00     ` Stefan Schmidt
2009-04-21  2:18       ` Dmitry Torokhov
2009-04-21  2:38         ` Daniel Ribeiro
2008-11-21 16:04 ` [patch 10/14] LED: PCAP2 based LED driver stefan
2008-11-22 14:08   ` Eric Miao
2008-11-22 15:46     ` Daniel Ribeiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227423962.3148.74.camel@brutus \
    --to=drwyrm@gmail.com \
    --cc=david-b@pacbell.net \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@openedhand.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=stefan@datenfreihafen.org \
    --cc=stefan@openmoko.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®