From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org
Subject: Re: [PATCH] Update the kmem_cache_create documentation regarding the name parameter
Date: Mon, 24 Nov 2008 09:56:04 +0200 [thread overview]
Message-ID: <1227513364.3718.0.camel@penberg-laptop> (raw)
In-Reply-To: <20081121125622.11468.97451.stgit@pc1117.cambridge.arm.com>
Hi Catalin,
On Fri, 2008-11-21 at 12:56 +0000, Catalin Marinas wrote:
> kmem_cache implementations like slub are allowed to merge multiple
> caches but only the initial name is preserved. Therefore,
> kmem_cache_name() is not guaranteed to return the same pointer passed to
> the former function. This patch updates the documentation to make this
> clearer.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Applied, thanks!
> ---
> mm/slab.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 4887f1b..8924a03 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -2124,6 +2124,8 @@ static int __init_refok setup_cpu_cache(struct kmem_cache *cachep)
> *
> * @name must be valid until the cache is destroyed. This implies that
> * the module calling this has to destroy the cache before getting unloaded.
> + * Note that kmem_cache_name() is not guaranteed to return the same pointer,
> + * therefore applications must manage it themselves.
> *
> * The flags are
> *
>
prev parent reply other threads:[~2008-11-24 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 12:56 Catalin Marinas
2008-11-24 7:56 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227513364.3718.0.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®