From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Hugh Dickins <hugh@veritas.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Miles Lane <miles.lane@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Tejun Heo <htejun@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vegard Nossum <vegard.nossum@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging request at ffff8800be8b0019
Date: Fri, 28 Nov 2008 09:56:50 +0200 [thread overview]
Message-ID: <1227859011.6039.2.camel@penberg-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0811271643250.9618@blonde.site>
On Thu, 2008-11-27 at 17:34 +0000, Hugh Dickins wrote:
> An alternative quick just-for-now fix might be to remove that
> namebuf[KSYM_NAME_LEN - 1] = 0;
> from kallsyms_lookup(): as I understand it (please check), that
> could only make sense in cases where the symbol is KSYM_NAME_LEN
> long or longer - in which case, all of the places fixed in the
> patch below would be causing corruption already, even without my
> patch. I think. Maybe that "= 0" even serves no purpose at all?
I looked into this and unfortunately that won't help us. For example,
module_address_lookup() will copy KSYM_NAME_LEN - 1 bytes to namebuf
anyway so we'll overflow the buffer.
It would probably be a good idea to add a comment to kallsyms_lookup()
stating that namebuf needs to have at least KSYM_NAME_LEN bytes
available.
Pekka
next prev parent reply other threads:[~2008-11-28 7:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 16:50 Miles Lane
2008-11-26 23:26 ` Rafael J. Wysocki
2008-11-27 13:37 ` Pekka Enberg
2008-11-27 13:50 ` Vegard Nossum
2008-11-27 13:54 ` Hugh Dickins
2008-11-27 14:13 ` Pekka Enberg
2008-11-27 17:34 ` Hugh Dickins
2008-11-27 21:23 ` Pekka Enberg
2008-11-27 21:56 ` Hugh Dickins
2008-11-27 22:51 ` Christoph Lameter
2008-11-28 7:57 ` Pekka Enberg
2008-11-27 23:27 ` Steven Rostedt
2008-11-27 23:31 ` Steven Rostedt
2008-11-28 0:16 ` Frederic Weisbecker
2008-11-29 6:40 ` Andrew Morton
2008-11-28 7:56 ` Pekka Enberg [this message]
2008-12-01 20:51 ` Andrew Morton
2008-12-01 22:47 ` Hugh Dickins
2008-12-02 0:57 ` Rusty Russell
2008-11-27 16:14 ` Miles Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227859011.6039.2.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=cl@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®