mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <stable@kernel.org>
Cc: <ath9k-devel@venema.h4ckr.net>, <linux-wireless@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sfr@canb.auug.org.au>,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>,
	Bennyam Malavazi <Bennyam.Malavazi@atheros.com>
Subject: [PATCH] ath9k: correct expected max RX buffer size
Date: Tue, 2 Dec 2008 12:51:21 -0800	[thread overview]
Message-ID: <1228251082-11677-3-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1228251082-11677-2-git-send-email-lrodriguez@atheros.com>

We should only tell the hardware its capable of DMA'ing
to us only what we asked dev_alloc_skb(). Prior to this
it is possible a large RX'd frame could have corrupted
DMA data but for us but we were saved only because we
were previously also pci_map_single()'ing the same large
value. The issue prior to this though was we were unmapping
a smaller amount which the prior DMA patch fixed.

Signed-off-by: Bennyam Malavazi <Bennyam.Malavazi@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/ath9k/recv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/recv.c b/drivers/net/wireless/ath9k/recv.c
index 4d23827..0941589 100644
--- a/drivers/net/wireless/ath9k/recv.c
+++ b/drivers/net/wireless/ath9k/recv.c
@@ -52,7 +52,7 @@ static void ath_rx_buf_link(struct ath_softc *sc, struct ath_buf *bf)
 	/* setup rx descriptors */
 	ath9k_hw_setuprxdesc(ah,
 			     ds,
-			     skb_tailroom(skb),   /* buffer size */
+			     sc->sc_rxbufsize,
 			     0);
 
 	if (sc->sc_rxlink == NULL)
-- 
1.5.6.rc2.15.g457bb.dirty


  reply	other threads:[~2008-12-02 20:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 20:51 [PATCH 0/3] ath9k: several fixes ported to 2.6.27 Luis R. Rodriguez
2008-12-02 20:51 ` [PATCH] ath9k: Fix SW-IOMMU bounce buffer starvation Luis R. Rodriguez
2008-12-02 20:51   ` Luis R. Rodriguez [this message]
2008-12-02 20:51     ` [PATCH 1/3] ath9k: Handle -ENOMEM on RX gracefully Luis R. Rodriguez
2008-12-03  0:12       ` [stable] " Greg KH
2008-12-03  0:20         ` Luis R. Rodriguez
2008-12-03  0:24           ` John W. Linville
2008-12-03 20:19             ` [ath9k-devel] " Luis R. Rodriguez
2008-12-03 20:32               ` Greg KH
2008-12-03 21:22             ` John W. Linville
2008-12-03 22:14               ` [ath9k-devel] " Luis R. Rodriguez
2008-12-02 20:57 ` [ath9k-devel] [PATCH 0/3] ath9k: several fixes ported to 2.6.27 Luis R. Rodriguez
2008-12-02 21:27 ` [stable] " Greg KH
2008-12-02 22:13   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228251082-11677-3-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=Bennyam.Malavazi@atheros.com \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®