From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933224AbcBPQNH (ORCPT ); Tue, 16 Feb 2016 11:13:07 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:55624 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932352AbcBPQNC (ORCPT ); Tue, 16 Feb 2016 11:13:02 -0500 From: Arnd Bergmann To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , Russell King , Bjorn Helgaas , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/4] gpio: ep93xx: remove private irq_to_gpio function Date: Tue, 16 Feb 2016 17:12:57 +0100 Message-ID: <12288210.VhBfyMlq8V@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <20160202194831.10827.63244.stgit@bhelgaas-glaptop2.roam.corp.google.com> <1455551208-2825510-4-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:1J3vqB23qTSjlsKLviECPWnGmu1uaZDwAwqd8+8KghWPEHSPEIT SmTKVEBx1jxkealRMEB1PdHRaVAPdwHqeyzUlDmEFjyzkNX9kv5QteJqUOliUQGSaX6ms8m 0MvqDKU4kxry4IjnLKTfUnlFq4G8vrSj/pUxAypYXj76C7CY4QsOzWLcC52m6KUctaqBBAz LRZfOLNVIsb87jaxNOheQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Dwzwz1n7rD8=:S+qT+PkVS+nZsQAqDRMuCv xWivWiCPTHfPYZHU/XJsJW1gbyWXmfFDvgbz+KXkU1IgA1W7mgW7GPHWGclw33hCpFDa7KeNg cK71xV6ppVeyP9uKfWwfq/q8u4ZntvvfDWEzoCU9NEbUK3gAh4uSLURBbGVyREZ/Vps/NOKVf kYcmDzYh9OsszuGnN2tYUpU9Tv9tf6/JE+QtFbhNBTisk/ab0J2Hlfu8wIlCEXlNh+t7PJ2c9 vD4n1GsWOBuCMMlK7yX0jhgXTTjYSfzK0b7cJtTG3jOBF/HizOZRxfBlHM+KAQv1CTY74LQC/ bFOgw8D1j1bF5tBRGFo5PubWu1OvYzyHd7gEmEcWRNAafmmBj5kJve5FjwuNGkT0MjE8u2NuV QwwXCPvGp5S478P1lm2RJY2FL4hydNxlQMjoGrCUkrH9tCCGbA4NZsXOlO2oxcLtg6LP8oGvx 2g2FY6fG6LzX0f8cIUxfVJitinXcMP40yeYPrFVM4d1XYMCWerJpQT9+6ZduUQfSxQDi9NZFQ swkzgcSQDEjxZr+WsSTlDPPQJ9NwWja51UCCU91LWcK7JexVLC6P3CQqx7dPn7PvdezOhR/+v htKSMrNL0K0z2s49rx3v30V/qUPNikLOOjdu6TSCByaaX1vl/cT+ootQNNvcASI2Zdy56w9El VFbHx/1fHWnullOzOU3utjqz9Ebbi3gttrD9Ie1IZM5RJ+nIht0ovXG/Jg3dhEsONE2qv3pSe SMpF5A8LWamqbBzD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 February 2016 16:51:57 Linus Walleij wrote: > On Mon, Feb 15, 2016 at 4:46 PM, Arnd Bergmann wrote: > > > The ep93xx goes through its own back-and-forth dance every time > > it wants to know the gpio number for an irq line, when it really > > just hardcodes a fixed offset in ep93xx_gpio_to_irq(). > > > > This removes the pointless macro and replaces the conversion inside > > of the driver with simple add/subtract operations, using an > > explicit macro. > > > > Signed-off-by: Arnd Bergmann > (...) > > > -#include > > -/* FIXME: this is here for gpio_to_irq() - get rid of this! */ > > #include > > No, what you want to get rid of is the #include not the > , we want to be more specific. Sorry for putting the > comment wrong. I think I initially did that, but ran into another build error then. > > > @@ -35,6 +31,7 @@ void __iomem *ep93xx_gpio_base; /* FIXME: put this into irq_data */ > > #define EP93XX_GPIO_LINE_MAX 63 > > > > /* maximum value for irq capable line identifiers */ > > +#define EP93XX_GPIO_IRQ_BASE 64 > > #define EP93XX_GPIO_LINE_MAX_IRQ 23 > > This doesn't apply to my tree :O > > My EP93XX_GPIO_LINE_MAX_IRQ is in > arch/arm/mach-ep93xx/include/mach/gpio-ep93xx.h > > So I think you must be having another patch somewhere in the ARM SoC > tree. (I can take it, just send it along with an update of this one.) Ah, that is right. Let's just drop this patch for now, it's not important. I have an old patch below to make the driver independent of the headers, but I have to look at that patch again before submitting it. I'll sort this one next to it. Arnd