From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727F0C61DB3 for ; Tue, 10 Jan 2023 09:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238239AbjAJJeE (ORCPT ); Tue, 10 Jan 2023 04:34:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238114AbjAJJdm (ORCPT ); Tue, 10 Jan 2023 04:33:42 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7359514094; Tue, 10 Jan 2023 01:33:41 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3443E2F4; Tue, 10 Jan 2023 01:34:23 -0800 (PST) Received: from [10.57.37.155] (unknown [10.57.37.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C73D3F587; Tue, 10 Jan 2023 01:33:39 -0800 (PST) Message-ID: <12288ed4-b4c4-cd53-ab0e-8b235e0852c0@arm.com> Date: Tue, 10 Jan 2023 09:33:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] perf kmem: Support legacy tracepoints Content-Language: en-US To: Leo Yan , Arnaldo Carvalho de Melo Cc: Ravi Bangoria , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230108062400.250690-1-leo.yan@linaro.org> <14dd06c2-39f8-ccb5-ce59-f3a1e45c94d0@arm.com> From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/2023 01:45, Leo Yan wrote: > On Mon, Jan 09, 2023 at 12:38:04PM -0300, Arnaldo Carvalho de Melo wrote: > > [...] > >>>> + const char * const slab_legacy_events[] = { >>>> + "-e", "kmem:kmalloc_node", >>>> + "-e", "kmem:kmem_cache_alloc_node", >>>> + }; >>> >>> Reviewed-by: James Clark >>> >>> This fixes the error with mem:kmalloc_node for me. > > Thanks for reviewing and testing! > >>> I was thinking that it might be best to add all events to the list >>> conditionally instead of just the legacy ones. That way, the same error >>> won't happen in the future. But maybe it's best to have an explicit >>> error again in case the breaking change was unintentional so it's fine >>> as it is I think. > > Yeah, this is a good idea for refactoring. > > James, do you mind to send patches for this? Do you not think there is any value in keeping it as showing an error for the next time one is removed? I was assuming that was your intention with this change, and I'm ok with keeping it that way for now. It's probably quite rare anyway so the refactor could be more effort than the gain. James > >> Just applied this, the changes you brains stormed may come as later >> patches, thanks, > > Thanks, Arnaldo. > > Leo