mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Huang Ying" <ying.huang@intel.com>,
	"Jeremy Fitzhardinge" <jeremy@goop.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"norman@thebacks.co.uk" <norman@thebacks.co.uk>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Greg KH" <gregkh@suse.de>,
	"Alok Kataria" <alokkataria1@gmail.com>,
	"Bruno Prémont" <"bruno .premont"@restena.lu>,
	"xl@xlsigned.net" <xl@xlsigned.net>,
	"dsd@gentoo.org" <dsd@gentoo.org>
Subject: Re: [PATCH] Fix VMI crash on boot in 2.6.27+ kernels
Date: Wed, 10 Dec 2008 21:44:32 -0800	[thread overview]
Message-ID: <1228974272.8766.59.camel@bodhitayantram.eng.vmware.com> (raw)
In-Reply-To: <49405CB6.6010006@kernel.org>

On Wed, 2008-12-10 at 16:20 -0800, Yinghai Lu wrote:
> it seems still have some problem.
> you moved reserve_top_address before parse_parameter...

I really only care about resetting fixmap_top.  Adding more vmalloc
space to accomodate what we stole is just being nice... in practice this
should not be a problem.

> __VMALLOC_RESERVE will be overwriten by vmalloc=...
> 
> you may need to split reserve_top_address() to two functions...

For now, misuse vmalloc=XXX at your own risk - why the need for it
anyway?

I agree, it should be cleaned up, as HPA suggests, we should move the
fixmap to a fixed place anyways, and have vmalloc area from the top of
linear memory down to the end of the physical memory mapping.  But there
really isn't time to do anything better for 2.6.28.

Zach


      parent reply	other threads:[~2008-12-11  4:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10  0:50 Zachary Amsden
2008-12-10  0:44 ` Greg KH
2008-12-10  7:30   ` Zachary Amsden
2008-12-10  1:15 ` Yinghai Lu
2008-12-10  1:48   ` H. Peter Anvin
2008-12-10  7:31     ` Zachary Amsden
2008-12-10  9:05       ` H. Peter Anvin
2008-12-10  7:36   ` Zachary Amsden
2008-12-11  0:06   ` Zachary Amsden
2008-12-11  0:20     ` Yinghai Lu
2008-12-11  3:31       ` Greg KH
2008-12-11 22:23         ` [PATCH] Fix VMI crash on boot in 2.6.27, 2.6.28 kernels Zachary Amsden
2008-12-11 21:45           ` Greg KH
2008-12-11 23:37             ` H. Peter Anvin
2008-12-12  5:37             ` Zachary Amsden
2008-12-11  5:44       ` Zachary Amsden [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228974272.8766.59.camel@bodhitayantram.eng.vmware.com \
    --to=zach@vmware.com \
    --cc="bruno .premont"@restena.lu \
    --cc=akpm@linux-foundation.org \
    --cc=alokkataria1@gmail.com \
    --cc=dsd@gentoo.org \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=norman@thebacks.co.uk \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=xl@xlsigned.net \
    --cc=ying.huang@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome