From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Slark Xiao <slark_xiao@163.com>,
loic.poulain@oss.qualcomm.com, ryazanov.s.a@gmail.com,
johannes@sipsolutions.net, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, gustavoars@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net] Revert "net: wwan: mhi_wwan_mbim: Avoid -Wflex-array-member-not-at-end warning"
Date: Tue, 20 Jan 2026 16:51:57 +0900 [thread overview]
Message-ID: <1228d107-4a60-4c33-a763-1a199c0b0961@embeddedor.com> (raw)
In-Reply-To: <20260120072018.29375-1-slark_xiao@163.com>
Hi Slark,
On 1/20/26 16:20, Slark Xiao wrote:
> This reverts commit eeecf5d3a3a484cedfa3f2f87e6d51a7390ed960.
>
> This change lead to MHI WWAN device can't connect to internet.
> I found a netwrok issue with kernel 6.19-rc4, but network works
> well with kernel 6.18-rc1. After checking, this commit is the
> root cause.
Thanks for the report.
Could you please apply the following patch on top of this revert,
and let us know if the problem still manifests? Thank you!
diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
index 1d7e3ad900c1..a271a72fed63 100644
--- a/drivers/net/wwan/mhi_wwan_mbim.c
+++ b/drivers/net/wwan/mhi_wwan_mbim.c
@@ -78,9 +78,12 @@ struct mhi_mbim_context {
struct mbim_tx_hdr {
struct usb_cdc_ncm_nth16 nth16;
- struct usb_cdc_ncm_ndp16 ndp16;
- struct usb_cdc_ncm_dpe16 dpe16[2];
+ __TRAILING_OVERLAP(struct usb_cdc_ncm_ndp16, ndp16, dpe16, __packed,
+ struct usb_cdc_ncm_dpe16 dpe16[2];
+ );
} __packed;
+static_assert(offsetof(struct mbim_tx_hdr, ndp16.dpe16) ==
+ offsetof(struct mbim_tx_hdr, dpe16));
static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim,
unsigned int session)
next prev parent reply other threads:[~2026-01-20 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 7:20 Slark Xiao
2026-01-20 7:51 ` Gustavo A. R. Silva [this message]
2026-01-20 9:16 ` Slark Xiao
2026-01-20 9:28 ` Gustavo A. R. Silva
2026-01-22 1:30 ` Slark Xiao
2026-01-22 2:14 ` Gustavo A. R. Silva
2026-01-22 2:18 ` Slark Xiao
2026-01-22 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228d107-4a60-4c33-a763-1a199c0b0961@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®