mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Adam Jackson <ajax@redhat.com>
Subject: [PATCH] PCI: Don't carp about BAR allocation failures in quiet boot
Date: Thu, 11 Dec 2008 17:13:45 -0500	[thread overview]
Message-ID: <1229033625-30825-4-git-send-email-ajax@redhat.com> (raw)
In-Reply-To: <1229033625-30825-3-git-send-email-ajax@redhat.com>

These are easy to trigger (more or less harmlessly) with multiple video
cards, since the ROM BAR will typically not be given any space by the
BIOS bridge setup.  No reason to punish quiet boot for this.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 arch/x86/pci/i386.c     |    4 ++--
 drivers/pci/setup-res.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 844df0c..43d9783 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -129,7 +129,7 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list)
 				pr = pci_find_parent_resource(dev, r);
 				if (!r->start || !pr ||
 				    request_resource(pr, r) < 0) {
-					dev_err(&dev->dev, "BAR %d: can't allocate resource\n", idx);
+					dev_info(&dev->dev, "BAR %d: can't allocate resource\n", idx);
 					/*
 					 * Something is wrong with the region.
 					 * Invalidate the resource to prevent
@@ -170,7 +170,7 @@ static void __init pcibios_allocate_resources(int pass)
 					r->flags, disabled, pass);
 				pr = pci_find_parent_resource(dev, r);
 				if (!pr || request_resource(pr, r) < 0) {
-					dev_err(&dev->dev, "BAR %d: can't allocate resource\n", idx);
+					dev_info(&dev->dev, "BAR %d: can't allocate resource\n", idx);
 					/* We'll assign a new address later */
 					r->end -= r->start;
 					r->start = 0;
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index 2dbd96c..4e37563 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -134,7 +134,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
 
 	align = resource_alignment(res);
 	if (!align) {
-		dev_err(&dev->dev, "BAR %d: can't allocate resource (bogus "
+		dev_info(&dev->dev, "BAR %d: can't allocate resource (bogus "
 			"alignment) %pR flags %#lx\n",
 			resno, res, res->flags);
 		return -EINVAL;
@@ -157,7 +157,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
 	}
 
 	if (ret) {
-		dev_err(&dev->dev, "BAR %d: can't allocate %s resource %pR\n",
+		dev_info(&dev->dev, "BAR %d: can't allocate %s resource %pR\n",
 			resno, res->flags & IORESOURCE_IO ? "I/O" : "mem", res);
 	} else {
 		res->flags &= ~IORESOURCE_STARTALIGN;
-- 
1.6.0.3


  reply	other threads:[~2008-12-11 22:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 22:13 [PATCH] net: Remove a noisy printk Adam Jackson
2008-12-11 22:13 ` [PATCH] ACPI: Silence blacklist warnings Adam Jackson
2008-12-11 22:13   ` [PATCH] x86: Don't print error for lack of i8042 chip Adam Jackson
2008-12-11 22:13     ` Adam Jackson [this message]
2008-12-11 22:26 ` [PATCH] net: Remove a noisy printk Sam Ravnborg
2008-12-12  4:32 ` David Miller
2008-12-13 22:13   ` Jan Engelhardt
2008-12-14 17:09     ` Jozsef Kadlecsik
2008-12-14 18:06       ` Jan Engelhardt
2008-12-14 20:15         ` Jozsef Kadlecsik
2008-12-15 12:23           ` Patrick McHardy
2008-12-15 13:25             ` Jozsef Kadlecsik
2008-12-15 13:32               ` Patrick McHardy
2008-12-14 20:03       ` Dave Jones
2008-12-16 19:59         ` Jozsef Kadlecsik
2008-12-16 20:03           ` Jan Engelhardt
2008-12-16 20:00         ` Jan Engelhardt
2008-12-17  8:26           ` Jozsef Kadlecsik
2008-12-19  1:21         ` Rusty Russell
2009-01-12  5:02           ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229033625-30825-4-git-send-email-ajax@redhat.com \
    --to=ajax@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®