On Wed, 2008-12-10 at 19:31 -0800, Greg KH wrote: > > +#ifdef CONFIG_VMI > > + /* VMI may relocate the fixmap; do this before touching ioremap area */ > > + vmi_init(); > > +#endif > > Shouldn't the #ifdef not be needed here if the .h files are set up > properly for the vmi_init prototype? Please try to keep them out of .c > files wherever possible. Yes, they should. Judging by setup.c though, you would think the opposite... in any case I fixed it. Please apply - and yes, I tested compile both ways.