From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages
Date: Wed, 17 Dec 2008 11:28:22 -0800 [thread overview]
Message-ID: <1229542103-24678-3-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20081217192737.GA24641@kroah.com>
From: Marcel Holtmann <marcel@holtmann.org>
Both messages are missing the newline and thus dmesg output gets
scrambled.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
lib/dynamic_printk.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d0fd0e4..8e30295 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -289,7 +289,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf,
dynamic_enabled = DYNAMIC_ENABLED_SOME;
err = 0;
printk(KERN_DEBUG
- "debugging enabled for module %s",
+ "debugging enabled for module %s\n",
elem->name);
} else if (!value && (elem->enable == 1)) {
elem->enable = 0;
@@ -309,7 +309,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf,
err = 0;
printk(KERN_DEBUG
"debugging disabled for module "
- "%s", elem->name);
+ "%s\n", elem->name);
}
}
}
--
1.6.0.4
next prev parent reply other threads:[~2008-12-17 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2008-12-17 19:28 ` [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module Greg Kroah-Hartman
2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
2008-12-17 23:08 ` Alan Cox
2008-12-17 23:45 ` Greg KH
2008-12-17 19:28 ` Greg Kroah-Hartman [this message]
2008-12-17 19:28 ` [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229542103-24678-3-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome