From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbYLVMQT (ORCPT ); Mon, 22 Dec 2008 07:16:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751065AbYLVMQG (ORCPT ); Mon, 22 Dec 2008 07:16:06 -0500 Received: from smtp.wellnetcz.com ([212.24.148.102]:40431 "EHLO smtp.wellnetcz.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbYLVMQE (ORCPT ); Mon, 22 Dec 2008 07:16:04 -0500 From: Jiri Slaby To: mchehab@infradead.org Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Jiri Slaby Subject: [PATCH 1/2] V4L: usbvideo, fix module ref count check Date: Mon, 22 Dec 2008 13:14:55 +0100 Message-Id: <1229948096-5254-1-git-send-email-jirislaby@gmail.com> X-Mailer: git-send-email 1.6.0.6 In-Reply-To: <1228767934-14193-1-git-send-email-jirislaby@gmail.com> References: <1228767934-14193-1-git-send-email-jirislaby@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -ENORESPONSE, CCing akpm -- usbvideo_ClientIncModCount may return value < 0 in the case of error, not > 0. Signed-off-by: Jiri Slaby Cc: Mauro Carvalho Chehab --- drivers/media/video/usbvideo/usbvideo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/usbvideo/usbvideo.c b/drivers/media/video/usbvideo/usbvideo.c index 7c575bb..6ace064 100644 --- a/drivers/media/video/usbvideo/usbvideo.c +++ b/drivers/media/video/usbvideo/usbvideo.c @@ -1123,7 +1123,7 @@ static int usbvideo_v4l_open(struct inode *inode, struct file *file) if (uvd->debug > 1) dev_info(&uvd->dev->dev, "%s($%p)\n", __func__, dev); - if (0 < usbvideo_ClientIncModCount(uvd)) + if (usbvideo_ClientIncModCount(uvd) < 0) return -ENODEV; mutex_lock(&uvd->lock); -- 1.6.0.5