mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcov: remove support for GCC < 4.9
Date: Thu, 12 Nov 2020 16:04:07 +0100	[thread overview]
Message-ID: <122d1259-19d5-008d-d290-62e22f279ffe@linux.ibm.com> (raw)
In-Reply-To: <20201111030557.2015680-1-ndesaulniers@google.com>

On 11.11.2020 04:05, Nick Desaulniers wrote:
> Since
> commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> the minimum supported version of GCC is gcc-4.9. It's now safe to remove
> this code.
> 
> Similar to
> commit 10415533a906 ("gcov: Remove old GCC 3.4 support")
> but that was for GCC 4.8 and this is for GCC 4.9.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/427
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Looks good, thanks!

Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>

Andrew, could you pick this up via your tree?

> ---
>  kernel/gcov/gcc_4_7.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index 53c67c87f141..0da0aacc1f26 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -25,10 +25,8 @@
>  #define GCOV_COUNTERS			9
>  #elif (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
>  #define GCOV_COUNTERS			10
> -#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
> -#define GCOV_COUNTERS			9
>  #else
> -#define GCOV_COUNTERS			8
> +#define GCOV_COUNTERS			9
>  #endif
>  
>  #define GCOV_TAG_FUNCTION_LENGTH	3
> 


-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany

      reply	other threads:[~2020-11-12 15:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  3:05 Nick Desaulniers
2020-11-12 15:04 ` Peter Oberparleiter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=122d1259-19d5-008d-d290-62e22f279ffe@linux.ibm.com \
    --to=oberpar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®