mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] headers_check.pl: disallow extern's
Date: Sat, 27 Dec 2008 02:43:36 -0500	[thread overview]
Message-ID: <1230363816-24097-1-git-send-email-vapier@gentoo.org> (raw)

Since prototypes with "extern" refer to kernel functions, they make no
sense in userspace, so reject them automatically.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 scripts/headers_check.pl |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 488a3b1..15b9bc6 100644
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -33,6 +33,7 @@ foreach my $file (@files) {
 	while ($line = <FH>) {
 		$lineno++;
 		check_include();
+		check_prototypes();
 	}
 	close FH;
 }
@@ -54,3 +55,11 @@ sub check_include
 		}
 	}
 }
+
+sub check_prototypes
+{
+	if ($line =~ m/^\s*extern\b/) {
+		printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
+		$ret = 1;
+	}
+}
-- 
1.6.0.6


             reply	other threads:[~2008-12-27  7:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-27  7:43 Mike Frysinger [this message]
2008-12-27 18:43 ` Sam Ravnborg
2008-12-27 18:54   ` Sam Ravnborg
2008-12-27 19:21     ` Mike Frysinger
2008-12-29 10:15     ` Mike Frysinger
2008-12-29 12:00       ` Sam Ravnborg
2008-12-27 19:23   ` Mike Frysinger
2008-12-31 16:58 ` Arnd Bergmann
2008-12-31 22:32   ` Mike Frysinger
2009-01-02 23:59     ` Arnd Bergmann
2009-01-03  0:05       ` Arjan van de Ven
2009-01-03  0:09         ` Arnd Bergmann
2009-01-03  1:20           ` Mike Frysinger
2009-01-03  1:40             ` Arnd Bergmann
2009-01-03  1:51 ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230363816-24097-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®