From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Dipankar Sarma <dipankar@in.ibm.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] kmemtrace: Use tracepoints instead of markers.
Date: Mon, 29 Dec 2008 15:43:56 +0200 [thread overview]
Message-ID: <1230558236.6078.13.camel@penberg-laptop> (raw)
In-Reply-To: <0d1bc24fa2c8d9df136cf833a36be2b72340bc8f.1230499486.git.eduard.munteanu@linux360.ro>
Hi Eduard,
On Mon, 2008-12-29 at 03:40 +0200, Eduard - Gabriel Munteanu wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index 1fcb32b..74d405d 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3624,8 +3624,9 @@ void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
> {
> void *ret = __cache_alloc(cachep, flags, __builtin_return_address(0));
>
> - kmemtrace_mark_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> - obj_size(cachep), cachep->buffer_size, flags);
> + trace_kmemtrace_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> + obj_size(cachep), cachep->buffer_size,
> + flags, -1);
One minor nit: I'd prefer we call these trace_kmem_cache_alloc(),
trace_kmalloc(), and so on. The trace_kmemtrace prefix doesn't really
make much sense to me.
next prev parent reply other threads:[~2008-12-29 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 1:40 [PATCH 0/3] kmemtrace over tracepoints Eduard - Gabriel Munteanu
2008-12-29 1:40 ` [PATCH 1/3] RCU: Move some definitions to minimal headers Eduard - Gabriel Munteanu
2008-12-29 1:40 ` [PATCH 2/3] tracepoints: Include only minimal RCU headers in linux/tracepoint.h Eduard - Gabriel Munteanu
2008-12-29 1:40 ` [PATCH 3/3] kmemtrace: Use tracepoints instead of markers Eduard - Gabriel Munteanu
2008-12-29 9:44 ` Pekka Enberg
2009-01-02 20:54 ` Mathieu Desnoyers
2009-01-02 23:03 ` Eduard - Gabriel Munteanu
2008-12-29 13:43 ` Pekka Enberg [this message]
2008-12-29 20:11 ` Eduard - Gabriel Munteanu
2009-01-02 20:53 ` Mathieu Desnoyers
2009-01-02 23:01 ` Eduard - Gabriel Munteanu
2009-01-02 23:42 ` Mathieu Desnoyers
2009-01-04 1:53 ` Eduard - Gabriel Munteanu
2009-01-04 4:10 ` Eduard - Gabriel Munteanu
2009-01-05 16:05 ` Mathieu Desnoyers
2009-01-05 17:57 ` Eduard - Gabriel Munteanu
2009-01-05 18:09 ` Mathieu Desnoyers
2008-12-29 9:42 ` [PATCH 1/3] RCU: Move some definitions to minimal headers Pekka Enberg
2008-12-29 12:32 ` Ingo Molnar
2008-12-30 6:31 ` Paul E. McKenney
2008-12-29 14:56 ` Ingo Molnar
2008-12-29 9:41 ` [PATCH 0/3] kmemtrace over tracepoints Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230558236.6078.13.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=adobriyan@gmail.com \
--cc=dipankar@in.ibm.com \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®