Re: [PATCH] afs: Move comments after /* fallthrough */

[David Howells <dhowells@redhat.com>]

Joe Perches <joe@perches.com> wrote:

> Make the code a bit easier for a script to appropriately convert
> case statement blocks with /* fallthrough */ comments to a macro by
> moving comments describing the next case block to the case statement.

This doesn't sound good.  Can you give an illustration of what a resulting
case might look like?  Say taking the following as an example:

> @@ -282,10 +282,8 @@ static int afs_deliver_cb_callback(struct afs_call *call)
>  	case 0:
>  		afs_extract_to_tmp(call);
>  		call->unmarshall++;
> -
> -		/* extract the FID array and its count in two steps */
>  		/* fall through */
> -	case 1:
> +	case 1:		/* extract the FID array and its count in two steps */
>  		_debug("extract FID count");
>  		ret = afs_extract_data(call, true);
>  		if (ret < 0)

David