mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Alessandro Suardi <alessandro.suardi@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.28-git3 and i915 Kconfig new dependency on framebuffer
Date: Fri, 02 Jan 2009 14:50:08 -0800	[thread overview]
Message-ID: <1230936608.6095.2.camel@gaiman.anholt.net> (raw)
In-Reply-To: <5a4c581d0812311055m5f9f395ci331457f9ed1d1a7f@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Wed, 2008-12-31 at 19:55 +0100, Alessandro Suardi wrote:
> make oldconfig from -git2 to -git3 doesn't build i915.ko unless
>  one has CONFIG_FB enabled; this causes /dev/dri/card0 to
>  be missing, and DRI disabled from within X.
> 
> Do I now (2.6.28-git3+) need CONFIG_FB to enable i915 DRM ?

Yes, the i915 driver now relies on fb code, though the new features are
runtime optional.  I may have noviced the Kconfig bits -- my intention
was "If you select I915, you also get all the CONFIG_FB-related bits
necessary".

config DRM_I915
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        depends on FB
        tristate "i915 driver"

I'm guessing that that "depends on FB" wants to be "select FB".

-- 
Eric Anholt
eric@anholt.net                         eric.anholt@intel.com



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-01-02 22:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31 18:55 Alessandro Suardi
2009-01-02 22:50 ` Eric Anholt [this message]
2009-01-02 23:02   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230936608.6095.2.camel@gaiman.anholt.net \
    --to=eric@anholt.net \
    --cc=alessandro.suardi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®