On Tue, 2009-01-06 at 18:31 -0500, Christoph Hellwig wrote:
> Just some minor comments:

I'm attaching a version fixing both yours comments and Harvey's.

> Please don't put filenames in top of file comments.  They don't serve
> any purpose and easily get out of date.

I've done that just to make it "fit-in" with the rest of the hfsplus
code, should I send a patch to remove those from the other files?

> No need for this comment I think.  All this is pretty well documented
> in Documentation/filesystems/Exporting, and all the other filesystems
> that just fill out these three methods don't comment on it either.

I copied over the code from ext2 sources, so at least one other
filesystem does comment on it ;)

But indeed it's misleading, better for it to be gone.

On Tue, 2009-01-06 at 15:49 -0800, Harvey Harrison wrote:
> One other nit, byteswap the constant so it can be done at compile-time:
> 
I copied over the code from dir.c, so I've propagated the change to
that, and also to super.c where a similar case was present, I'm
attaching it at 0002 (but maybe it should go in before the NFS export
support?).

I've not checked if there are other cases where this can be optimised
though, maybe I should.

If you all are in mood of HFS+ patches review, I might try to run the
code through a couple of my tools, I had in my TODO list to try them on
kernel code for a while ;)

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/