From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756460AbZAGQgf (ORCPT ); Wed, 7 Jan 2009 11:36:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751796AbZAGQg0 (ORCPT ); Wed, 7 Jan 2009 11:36:26 -0500 Received: from wf-out-1314.google.com ([209.85.200.171]:59734 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbZAGQgZ (ORCPT ); Wed, 7 Jan 2009 11:36:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=oh5iHxo3120ArGS0FMatZ3f1Uif5PV6wAj2x2mBXgByAzQ0dgQ3MzsJZO80Z6XVgNZ TsY/Gsxy/VL0/DzByuIql7Z/dAl82OzHDzUhCLYBXAtqFbLeEVQclOFjbbje3/u0re77 VXSjBkhDjRm5i7cN5VF3iVVybIXEIyPGZe0xI= From: Bryan Wu To: jeff@garzik.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Sonic Zhang , Bryan Wu Subject: [PATCH 1/1] pata: fix bug - __pata_platform_remove() should not be in discarded section Date: Thu, 8 Jan 2009 00:37:12 +0800 Message-Id: <1231346232-27861-1-git-send-email-cooloney@kernel.org> X-Mailer: git-send-email 1.5.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sonic Zhang -- UPD include/linux/compile.h `___pata_platform_remove' referenced in section `__ksymtab_gpl' of drivers/built-in.o: defined in discarded section `.devexit.text' of drivers/built-in.o make: *** [.tmp_vmlinux1] Error 1 -- __pata_platform_remove() should not be in discarded section __pata_platform_remove(struct device *dev) is invoked in both pata_platform.c and pata_of_platform.c by reomve function defined in discarded section ".devexit.text". An exported function should not be put into discarded section. Signed-off-by: Sonic Zhang Signed-off-by: Bryan Wu --- drivers/ata/pata_platform.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c index 6afa07a..d8d743a 100644 --- a/drivers/ata/pata_platform.c +++ b/drivers/ata/pata_platform.c @@ -186,7 +186,7 @@ EXPORT_SYMBOL_GPL(__pata_platform_probe); * A platform bus ATA device has been unplugged. Perform the needed * cleanup. Also called on module unload for any active devices. */ -int __devexit __pata_platform_remove(struct device *dev) +int __pata_platform_remove(struct device *dev) { struct ata_host *host = dev_get_drvdata(dev); -- 1.5.6