From: Harvey Harrison <harvey.harrison@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Greg Kroah-Hartman <greg@kroah.com>, Pavel Machek <pavel@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] w35und: Move ETH_LENGTH_OF_ADDRESS to wbhal_s.h
Date: Thu, 08 Jan 2009 02:13:30 -0800 [thread overview]
Message-ID: <1231409610.5539.7.camel@brick> (raw)
In-Reply-To: <1231408613.9373.5.camel@penberg-laptop>
On Thu, 2009-01-08 at 11:56 +0200, Pekka Enberg wrote:
> On Thu, 2009-01-08 at 01:46 -0800, Harvey Harrison wrote:
> > On Thu, 2009-01-08 at 11:30 +0200, Pekka J Enberg wrote:
> > > From: Pekka Enberg <penberg@cs.helsinki.fi>
> > >
> > > +#define ETH_LENGTH_OF_ADDRESS 6
> >
> > Or just use ETH_ALEN like the rest of the kernel and drop this guy.
>
> Even better, thanks Harvey! Greg, please use this one instead. The rest
> of the series is unaffected by the changes in this patch.
>
> >From c849ed5b5e68953a72f8dc43066513f118822f94 Mon Sep 17 00:00:00 2001
> From: Pekka Enberg <penberg@cs.helsinki.fi>
> Date: Thu, 8 Jan 2009 11:10:06 +0200
> Subject: [PATCH] w35und: convert code to use ETH_ALEN
>
> As suggested by Harvey Harrison, convert driver to use ETH_ALEN and kill a
> private macro from common.h that is used for the same thing.
Untested, but obviously ACK the approach :-)
Harvey
prev parent reply other threads:[~2009-01-08 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 9:30 Pekka J Enberg
2009-01-08 9:46 ` Harvey Harrison
2009-01-08 9:56 ` Pekka Enberg
2009-01-08 10:08 ` Pavel Machek
2009-01-08 10:13 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231409610.5539.7.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®