mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Grissiom <chaos.proton@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
Date: Thu, 08 Jan 2009 09:46:31 -0600	[thread overview]
Message-ID: <1231429591.27353.14.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <20090108072111.1ebadebd@infradead.org>

sync_filesystems() shouldn't be calling async_synchronize_full_special
while holding a spinlock.  The second while loop in that function is the
right place for this anyway.

Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Reported-by: Grissiom <chaos.proton@gmail.com>

diff --git a/fs/super.c b/fs/super.c
index cb20744..7d67387 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -458,7 +458,6 @@ void sync_filesystems(int wait)
 		if (sb->s_flags & MS_RDONLY)
 			continue;
 		sb->s_need_sync_fs = 1;
-		async_synchronize_full_special(&sb->s_async_list);
 	}
 
 restart:
@@ -471,6 +470,7 @@ restart:
 		sb->s_count++;
 		spin_unlock(&sb_lock);
 		down_read(&sb->s_umount);
+		async_synchronize_full_special(&sb->s_async_list);
 		if (sb->s_root && (wait || sb->s_dirt))
 			sb->s_op->sync_fs(sb, wait);
 		up_read(&sb->s_umount);

-- 
David Kleikamp
IBM Linux Technology Center


  reply	other threads:[~2009-01-08 15:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08  8:07 "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom
2009-01-08 14:37 ` Dave Kleikamp
2009-01-08 15:21   ` Arjan van de Ven
2009-01-08 15:46     ` Dave Kleikamp [this message]
2009-01-08 22:50       ` [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock Dave Chinner
2009-01-08 22:51         ` Arjan van de Ven
2009-01-09  0:32           ` Alan Cox
2009-01-09  0:38             ` Arjan van de Ven
2009-01-09  1:40           ` Dave Chinner
2009-01-09  4:45             ` Arjan van de Ven
2009-01-09  8:22               ` Dave Chinner
2009-01-09 15:09                 ` Chris Mason
2009-01-12  2:31               ` Jamie Lokier
2009-01-12  3:54                 ` Arjan van de Ven
2009-01-12  7:55                   ` Dave Chinner
2009-01-12  7:48                 ` Dave Chinner
2009-01-09 12:31         ` Evgeniy Polyakov
2009-01-09  5:18   ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231429591.27353.14.camel@norville.austin.ibm.com \
    --to=shaggy@linux.vnet.ibm.com \
    --cc=arjan@linux.intel.com \
    --cc=chaos.proton@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®