mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Andreas Dilger <adilger@sun.com>
Cc: coly.li@suse.de, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	"Sergey S. Kostyliov" <rathamahata@php4.ru>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	Bob Copeland <me@bobcopeland.com>, Anders Larsen <al@alarsen.net>,
	reiserfs-devel@vger.kernel.org,
	Phillip Lougher <phillip@lougher.demon.co.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Evgeniy Dushistov <dushistov@mail.ru>, Jan Kara <jack@suse.cz>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/20] return f_fsid for statfs(2)
Date: Mon, 19 Jan 2009 20:39:09 -0600	[thread overview]
Message-ID: <1232419149.19468.3.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <20090119233651.GK3286@webber.adilger.int>

On Tue, 2009-01-20 at 07:36 +0800, Andreas Dilger wrote:
> On Jan 19, 2009  13:28 -0600, Dave Kleikamp wrote:
> > ext[234] return a portion of the uuid in f_fsid.  There is a theoretical
> > chance of those values being non-unique.  Since there doesn't appear to
> > be any case for the fsid to be persistent between boots, I guess
> > huge_encode_dev() is probably a better choice.  In practice it probably
> > makes no difference.
> 
> I'm not sure what you mean about "no case for fsid to be persistent"?
> The whole point of fsid (for NFS) is that this identifies the filesystem
> over reboot, even if the block device ID changes, or if the filesystem
> doesn't have a block device at all (e.g. cluster filesystem).

I guess that just demonstrates how little I know about what the fsid is
about.  Would it be preferable for file systems that have a uuid to use
that instead?  Of course anything is an improvement over zeroes.

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center


  reply	other threads:[~2009-01-20  2:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 17:30 Coly Li
2009-01-19 19:28 ` Dave Kleikamp
2009-01-19 23:36   ` Andreas Dilger
2009-01-20  2:39     ` Dave Kleikamp [this message]
2009-01-20  4:13       ` Andreas Dilger
2009-01-20  4:30         ` Coly Li
2009-01-20  4:44           ` Andreas Dilger
2009-01-20  7:03             ` Coly Li
2009-01-20 18:48             ` Jamie Lokier
2009-01-22 19:36               ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232419149.19468.3.camel@norville.austin.ibm.com \
    --to=shaggy@linux.vnet.ibm.com \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=al@alarsen.net \
    --cc=coly.li@suse.de \
    --cc=dushistov@mail.ru \
    --cc=hch@infradead.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@bobcopeland.com \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=phillip@lougher.demon.co.uk \
    --cc=rathamahata@php4.ru \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®