mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/5] sysfs: fix problems with binary files
Date: Tue, 20 Jan 2009 21:19:55 -0800	[thread overview]
Message-ID: <1232515197-3974-3-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20090121051855.GA3665@kroah.com>

Some sysfs binary files don't like having 0 passed to them as a size.
Fix this up at the root by just returning to the vfs if userspace asks
us for a zero sized buffer.

Thanks to Pavel Roskin for pointing this out.

Reported-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 fs/sysfs/bin.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
index 66f6e58..f2c478c 100644
--- a/fs/sysfs/bin.c
+++ b/fs/sysfs/bin.c
@@ -63,6 +63,9 @@ read(struct file *file, char __user *userbuf, size_t bytes, loff_t *off)
 	int count = min_t(size_t, bytes, PAGE_SIZE);
 	char *temp;
 
+	if (!bytes)
+		return 0;
+
 	if (size) {
 		if (offs > size)
 			return 0;
@@ -131,6 +134,9 @@ static ssize_t write(struct file *file, const char __user *userbuf,
 	int count = min_t(size_t, bytes, PAGE_SIZE);
 	char *temp;
 
+	if (!bytes)
+		return 0;
+
 	if (size) {
 		if (offs > size)
 			return 0;
-- 
1.6.0.4


  parent reply	other threads:[~2009-01-21  5:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21  5:18 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2009-01-21  5:19 ` [PATCH 1/5] driver core: Convert '/' to '!' in dev_set_name() Greg Kroah-Hartman
2009-01-21  5:19 ` [PATCH 2/5] PNP: fix broken pnp lowercasing for acpi module aliases Greg Kroah-Hartman
2009-01-21  5:19 ` Greg Kroah-Hartman [this message]
2009-01-21  5:19 ` [PATCH 4/5] debugfs: introduce stub for debugfs_create_size_t() when DEBUG_FS=n Greg Kroah-Hartman
2009-01-22  6:41   ` Stephen Rothwell
2009-01-22 18:22     ` Greg KH
2009-01-22 19:53       ` Inaky Perez-Gonzalez
2009-01-21  5:19 ` [PATCH 5/5] klist.c: bit 0 in pointer can't be used as flag Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232515197-3974-3-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome