mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: linux-kernel@vger.kernel.org
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Milton Miller <miltonm@bga.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH] HVC: do not request the irq twice.
Date: Thu, 22 Jan 2009 17:56:08 +0000	[thread overview]
Message-ID: <1232646968-32671-1-git-send-email-Ian.Campbell@citrix.com> (raw)

Otherwise:
  root@bogga:~# tty
  /dev/hvc0
  root@bogga:~# reboot


  Broadcast message from root@bogga (hvc0) (Thu Jan 22 17:51:20 2009):

  The system is going down for reboot NOW!
  INIT: Switching to runlevel: 6
  INIT: Sending processes the TERM signal
  hvc_open: request_irq failed with rc -16.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Milton Miller <miltonm@bga.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
 drivers/char/hvc_irq.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/char/hvc_irq.c b/drivers/char/hvc_irq.c
index 2623e17..8152a13 100644
--- a/drivers/char/hvc_irq.c
+++ b/drivers/char/hvc_irq.c
@@ -28,6 +28,10 @@ int notifier_add_irq(struct hvc_struct *hp, int irq)
 		hp->irq_requested = 0;
 		return 0;
 	}
+
+	if (hp->irq_requested)
+		return 0;
+
 	rc = request_irq(irq, hvc_handle_interrupt, IRQF_DISABLED,
 			   "hvc_console", hp);
 	if (!rc)
-- 
1.5.6.5


             reply	other threads:[~2009-01-22 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 17:56 Ian Campbell [this message]
2009-01-22 19:09 ` Christian Borntraeger
2009-01-23  9:45   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232646968-32671-1-git-send-email-Ian.Campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miltonm@bga.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®