From: Ed Swierk <eswierk@aristanetworks.com>
To: rml@tech9.net, linux-kernel@vger.kernel.org,
kpreempt-tech@lists.sourceforge.net
Subject: [PATCH] Fix BUG: using smp_processor_id() in preemptible code in print_fatal_signal()
Date: Mon, 26 Jan 2009 15:00:18 -0800 [thread overview]
Message-ID: <1233010818.14510.11.camel@localhost.localdomain> (raw)
With print-fatal-signals=1 on a kernel with CONFIG_PREEMPT=y, sending an
unexpected signal to a process causes a BUG: using smp_processor_id() in
preemptible code.
get_signal_to_deliver() releases the siglock before calling
print_fatal_signal(), which calls show_regs(), which calls
smp_processor_id(), which is not supposed to be called from a
preemptible thread.
Calling print_fatal_signal() before releasing the siglock avoids this
problem.
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
Index: linux-2.6.27.4/kernel/signal.c
===================================================================
--- linux-2.6.27.4.orig/kernel/signal.c
+++ linux-2.6.27.4/kernel/signal.c
@@ -1848,6 +1848,11 @@ relock:
continue;
}
+ if (sig_kernel_coredump(signr) && print_fatal_signals) {
+ /* hold lock for smp_processor_id() */
+ print_fatal_signal(regs, info->si_signo);
+ }
+
spin_unlock_irq(&sighand->siglock);
/*
@@ -1856,8 +1861,6 @@ relock:
current->flags |= PF_SIGNALED;
if (sig_kernel_coredump(signr)) {
- if (print_fatal_signals)
- print_fatal_signal(regs, info->si_signo);
/*
* If it was able to dump core, this kills all
* other threads in the group and synchronizes with
next reply other threads:[~2009-01-26 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 23:00 Ed Swierk [this message]
2009-01-26 23:15 ` Ingo Molnar
2009-01-26 23:33 ` Ed Swierk
2009-01-26 23:37 ` Ingo Molnar
2009-01-27 0:41 ` Oleg Nesterov
2009-01-27 1:34 ` Ed Swierk
2009-01-27 3:02 ` Oleg Nesterov
2009-01-27 12:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233010818.14510.11.camel@localhost.localdomain \
--to=eswierk@aristanetworks.com \
--cc=kpreempt-tech@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome