mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, coly.li@suse.de
Subject: Re: [PATCH 11/20] fs/jfs: return f_fsid for statfs(2), v3
Date: Tue, 27 Jan 2009 10:06:29 -0600	[thread overview]
Message-ID: <1233072389.3779.82.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <1233062766.3779.3.camel@norville.austin.ibm.com>

On Tue, 2009-01-27 at 07:26 -0600, Dave Kleikamp wrote:
> Andrew,
> Please take this version of the jfs patch, rather than the one you
> currently have in the -mm tree (fs-jfs-return-f_fsid-for-statfs2.patch).

... or would you rather I handle it though the jfs tree and you drop it?

Shaggy

> On Wed, 2009-01-21 at 00:05 +0800, Coly Li wrote:
> > This patch makes jfs return f_fsid info for statfs(2). By Andreas' suggestion, this patch populates
> > a persistent f_fsid between boots/mounts with help of on-disk uuid record.
> > 
> > Signed-off-by: Coly Li <coly.li@suse.de>
> > Acked-By: Dave Kleikamp <shaggy@austin.ibm.com>
> > ---
> >  fs/jfs/super.c |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> > index b37d1f7..6ce1aac 100644
> > --- a/fs/jfs/super.c
> > +++ b/fs/jfs/super.c
> > @@ -29,6 +29,7 @@
> >  #include <linux/posix_acl.h>
> >  #include <linux/buffer_head.h>
> >  #include <linux/exportfs.h>
> > +#include <linux/crc32.h>
> >  #include <asm/uaccess.h>
> >  #include <linux/seq_file.h>
> > 
> > @@ -168,7 +169,10 @@ static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf)
> >  	buf->f_files = maxinodes;
> >  	buf->f_ffree = maxinodes - (atomic_read(&imap->im_numinos) -
> >  				    atomic_read(&imap->im_numfree));
> > -
> > +	buf->f_fsid.val[0] = (u32)crc32_le(0, sbi->uuid, sizeof(sbi->uuid)/2);
> > +	buf->f_fsid.val[1] = (u32)crc32_le(0, sbi->uuid + sizeof(sbi->uuid)/2,
> > +					sizeof(sbi->uuid)/2);
> > +
> >  	buf->f_namelen = JFS_NAME_MAX;
> >  	return 0;
> >  }
> > 
-- 
David Kleikamp
IBM Linux Technology Center


  reply	other threads:[~2009-01-27 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 16:05 Coly Li
2009-01-27 13:26 ` Dave Kleikamp
2009-01-27 16:06   ` Dave Kleikamp [this message]
2009-01-27 16:43     ` Andrew Morton
2009-01-27 17:31       ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233072389.3779.82.camel@norville.austin.ibm.com \
    --to=shaggy@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=coly.li@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®