From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755671AbZA0WL4 (ORCPT ); Tue, 27 Jan 2009 17:11:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752755AbZA0WLq (ORCPT ); Tue, 27 Jan 2009 17:11:46 -0500 Received: from smtp118.sbc.mail.sp1.yahoo.com ([69.147.64.91]:41382 "HELO smtp118.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751133AbZA0WLp (ORCPT ); Tue, 27 Jan 2009 17:11:45 -0500 X-YMail-OSG: KpQlwPIVM1nac8ejLYJ4Pvg3JLKTyDDbFUXBiEbbl_cB4b_aFbG4.fJ3dAl4IWDyr4KN53Us4Ih0paxZSVhGSAwEssCeIPy5cgi2TyTbarRwMde7B5_ESoJ6m1hkytlyWBmn9lxWWBvXzk5rHjbIGbN1q5bfM2ndr1er7b7kQGRX12VJdOwjeVUMDgyRlPGtdadWltf1gZtSl9WyzA8L4a2ibgn8JarTPthqdWmJu93s9CIpzSo- X-Yahoo-Newman-Property: ymail-3 Subject: Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL From: "Nicholas A. Bellinger" To: "Linux-iSCSI.org Target Dev" Cc: LKML , linux-scsi , James Bottomley In-Reply-To: <1233093749.6442.97.camel@haakon2.linux-iscsi.org> References: <1233093749.6442.97.camel@haakon2.linux-iscsi.org> Content-Type: text/plain Date: Tue, 27 Jan 2009 14:10:36 -0800 Message-Id: <1233094236.6442.110.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, Let me know if you need a fresh respin of this patch.. According to spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only VARIABLE_LENGTH_CMD defined Service ACtion.. --nab On Tue, 2009-01-27 at 14:02 -0800, Nicholas A. Bellinger wrote: > >From 9147996b858bc44d8253929fe0cb4acfa9795986 Mon Sep 17 00:00:00 2001 > From: Nicholas Bellinger > Date: Tue, 27 Jan 2009 13:29:49 -0800 > Subject: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL > > This patch adds the VARIABLE_LENGTH_CMD Service Action code: > VLC_SA_RECEIVE_CREDENTIAL and removes the incorrect CDB byte[0] > opcode define RECEIVE_CREDENTIAL. > > Signed-off-by: Nicholas A. Bellinger > --- > include/scsi/scsi.h | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index 93af6ce..aabd3d1 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -104,7 +104,6 @@ > #define PERSISTENT_RESERVE_IN 0x5e > #define PERSISTENT_RESERVE_OUT 0x5f > #define VARIABLE_LENGTH_CMD 0x7f > -#define RECEIVE_CREDENTIAL 0x7f // spc4r17 section 6.9 Table 204 > #define REPORT_LUNS 0xa0 > #define SECURITY_PROTOCOL_IN 0xa2 > #define MAINTENANCE_IN 0xa3 > @@ -134,6 +133,9 @@ > #define SERVICE_ACTION_IN 0x9e > /* values for service action in */ > #define SAI_READ_CAPACITY_16 0x10 > +/* values for VARIABLE_LENGTH_CMD service action codes > + * see spc4r17 Section D.3.5, table D.7 and D.8 */ > +#define VLC_SA_RECEIVE_CREDENTIAL 0x1800 > /* values for maintenance in */ > #define MI_REPORT_IDENTIFYING_INFORMATION 0x05 > #define MI_REPORT_TARGET_PGS 0x0a