From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] slub: fix per cpu kmem_cache_cpu array memory leak
Date: Wed, 28 Jan 2009 11:27:44 +0200 [thread overview]
Message-ID: <1233134864.16201.3.camel@penberg-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.0901280115470.28944@chino.kir.corp.google.com>
Hi David,
On Wed, 28 Jan 2009, Pekka Enberg wrote:
> > Btw, did you hit this bug during testing or did you just spot it
> > during review? That is, do we need to get this to -stable?
On Wed, 2009-01-28 at 01:20 -0800, David Rientjes wrote:
> I ran into it while hacking the per cpu arrays, but haven't witnessed it
> on a vanilla kernel. Since there are no guarantees that a kmem_cache_cpu
> will not be allocated on this boundary, I would recommend it for -stable.
Documentation/stable_kernel_rules.txt states that:
- It must fix a real bug that bothers people (not a, "This could be a
problem..." type thing).
The bug has been there for a very long time and hasn't generated any bug
reports so I think I'll just push it to mainline and leave it that.
Thanks!
Pekka
next prev parent reply other threads:[~2009-01-28 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 2:59 David Rientjes
2009-01-28 8:52 ` Pekka Enberg
2009-01-28 8:58 ` Pekka Enberg
2009-01-28 9:20 ` David Rientjes
2009-01-28 9:27 ` Pekka Enberg [this message]
2009-01-28 16:40 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233134864.16201.3.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®