mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: greg@kroah.com
Cc: chrisw@sous-sol.org, stable@kernel.org,
	linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH stable-28 1/3] NET: net_namespace, fix lock imbalance
Date: Wed, 28 Jan 2009 18:53:39 +0100	[thread overview]
Message-ID: <1233165221-20106-3-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1233165221-20106-2-git-send-email-jslaby@suse.cz>

From: Jiri Slaby <jirislaby@gmail.com>

register_pernet_gen_subsys omits mutex_unlock in one fail path.
Fix it.

Commit 357f5b0b91054ae23385ea4b0634bb8b43736e83.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/core/net_namespace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 1895a4c..0bc398c 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -342,8 +342,8 @@ again:
 	rv = register_pernet_operations(first_device, ops);
 	if (rv < 0)
 		ida_remove(&net_generic_ids, *id);
-	mutex_unlock(&net_mutex);
 out:
+	mutex_unlock(&net_mutex);
 	return rv;
 }
 EXPORT_SYMBOL_GPL(register_pernet_gen_subsys);
-- 
1.6.1


  reply	other threads:[~2009-01-28 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 17:53 [PATCH stable-27 1/2] PCI hotplug: fix lock imbalance in pciehp Jiri Slaby
2009-01-28 17:53 ` [PATCH stable-27 2/2] relay: fix lock imbalance in relay_late_setup_files Jiri Slaby
2009-01-28 17:53   ` Jiri Slaby [this message]
2009-01-28 17:53     ` [PATCH stable-28 2/3] PCI hotplug: fix lock imbalance in pciehp Jiri Slaby
2009-01-28 17:53       ` [PATCH stable-28 3/3] relay: fix lock imbalance in relay_late_setup_files Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233165221-20106-3-git-send-email-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®