From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758932AbZA2XhM (ORCPT ); Thu, 29 Jan 2009 18:37:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752213AbZA2Xgy (ORCPT ); Thu, 29 Jan 2009 18:36:54 -0500 Received: from smtp115.sbc.mail.sp1.yahoo.com ([69.147.64.88]:33350 "HELO smtp115.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753090AbZA2Xgx (ORCPT ); Thu, 29 Jan 2009 18:36:53 -0500 X-YMail-OSG: VrjkYSUVM1lvqCnF7Heb.adUo8nKe6R_ma0hOJ3J0KUaLE58M15jGnYWezasDu4Jnj4wpKSJFrCD66FWynlefw5G3DviX3TyxpAjmRHvD38vz8RemoeXbXGLXBkbJTo7MO2pwiumLfbr6NQtZWLw.5dgPQlm2zRioFbBpLUuRIzN.YnkkZy11FPheYkeLZZ7COgc1CV7ZPjN6p0zGkGwO7OQcmRf4j4- X-Yahoo-Newman-Property: ymail-3 Subject: Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL From: "Nicholas A. Bellinger" To: Boaz Harrosh Cc: LKML , linux-scsi , James Bottomley In-Reply-To: <4981972A.2090801@panasas.com> References: <1233093749.6442.97.camel@haakon2.linux-iscsi.org> <1233094236.6442.110.camel@haakon2.linux-iscsi.org> <4981972A.2090801@panasas.com> Content-Type: text/plain Date: Thu, 29 Jan 2009 15:31:35 -0800 Message-Id: <1233271895.6442.220.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2009-01-29 at 13:46 +0200, Boaz Harrosh wrote: > Nicholas A. Bellinger wrote: > > Hi James, > > > > Let me know if you need a fresh respin of this patch.. According to > > spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only > > VARIABLE_LENGTH_CMD defined Service ACtion.. > > > > --nab > > Not accurate. See file include/scsi/osd_protocol.h in the scsi-misc > git-tree master branch. The complete OSD command set is VARIABLE_LENGTH_CMD > based. There must be others as well > Ok, what I meant was: >>From searching spc4r17, VLC_SA_RECEIVE_CREDENTIAL (0x1800) is the only SPC-4 defined VARIABLE_LENGTH_CMD defined Service Action in Table D.8. >>From SPC-4, the range 0x1800 -> 0x1FFF is reserved for SPC-4 defined VARIABLE_LENGTH_CMD SAs. I see that OSD SAs for VARIABLE_LENGTH_CMD opcode are defined in range 0x8800 -> 0x8FFF, so does not it make sense to add the single VLC_SA_* prefixed define above for range 0x1800 -> 0x1FFF in include/scsi/scsi.h..? Many thanks for your most valuable of time, --nab > Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >