From: Johannes Berg <johannes@sipsolutions.net>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Pavel Machek <pavel@suse.cz>,
Sandro Bonazzola <sandro.bonazzola@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Bruno Randolf <br1@einfach.org>
Subject: Re: [PATCH] w35und: fix registration with wlan stack
Date: Fri, 30 Jan 2009 10:16:20 +0100 [thread overview]
Message-ID: <1233306980.4161.19.camel@johannes.local> (raw)
In-Reply-To: <1233306825.13655.28.camel@penberg-laptop>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On Fri, 2009-01-30 at 11:13 +0200, Pekka Enberg wrote:
> > dev->extra_tx_headroom = 12; /* FIXME */
> > - dev->flags = 0;
> > + dev->flags = IEEE80211_HW_SIGNAL_UNSPEC;
> > + dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
>
> The wiphy->interface_modes thing is probably fall-out from commit
> 8dffff216fcac4f79078478085e86d68db64922e ("mac80211: only create default
> STA interface if supported"). I'm cc'ing Johannes.
Yes. That looks reasonable, though it means you'll only support STA, not
ad-hoc.
> >
> > dev->channel_change_time = 1000;
> > + dev->max_signal = 100;
>
> And the IEEE80211_HW_SIGNAL_UNSPEC and ->max_signal from commit
> 566bfe5a8bcde13188a356f77666f8115813cf31 ("mac80211: use hardware flags
> for signal/noise units"). Lets cc Bruno.
Seems reasonable, though does it would be good to see if it can do DBM,
which we very very much prefer.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-30 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <497E1F3A.1060604@cs.helsinki.fi>
[not found] ` <497E2EC4.5030302@gmail.com>
[not found] ` <497E35A1.8080301@cs.helsinki.fi>
[not found] ` <497F5FEA.7020203@gmail.com>
[not found] ` <20090127200602.GA16444@elf.ucw.cz>
[not found] ` <4980B2DD.307@gmail.com>
[not found] ` <4980BB9A.2020309@cs.helsinki.fi>
[not found] ` <4980C028.2030709@gmail.com>
[not found] ` <4980C035.4070105@cs.helsinki.fi>
[not found] ` <4980DB5D.6010906@gmail.com>
2009-01-30 9:05 ` Pavel Machek
2009-01-30 9:13 ` Pekka Enberg
2009-01-30 9:16 ` Johannes Berg [this message]
2009-01-30 9:38 ` Pavel Machek
2009-01-30 9:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233306980.4161.19.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=br1@einfach.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=sandro.bonazzola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®