mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <philipp.zabel@gmail.com>
To: Samuel Ortiz <sameo@openedhand.com>
Cc: linux-kernel@vger.kernel.org, Philipp Zabel <philipp.zabel@gmail.com>
Subject: [PATCH] mfd: DS1WM: remove warning about unused label err2
Date: Fri,  6 Feb 2009 17:31:40 +0100	[thread overview]
Message-ID: <1233937900-18710-1-git-send-email-philipp.zabel@gmail.com> (raw)
In-Reply-To: <1233852820-28549-6-git-send-email-philipp.zabel@gmail.com>

Hi Samuel,

thanks for queuing the patchset. Could you please fold this into the DS1WM clock removal patch? 

Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
 drivers/w1/masters/ds1wm.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
index b982aa6..37f08c8 100644
--- a/drivers/w1/masters/ds1wm.c
+++ b/drivers/w1/masters/ds1wm.c
@@ -387,13 +387,12 @@ static int ds1wm_probe(struct platform_device *pdev)
 
 	ret = w1_add_master_device(&ds1wm_master);
 	if (ret)
-		goto err3;
+		goto err2;
 
 	return 0;
 
-err3:
-	ds1wm_down(ds1wm_data);
 err2:
+	ds1wm_down(ds1wm_data);
 	free_irq(ds1wm_data->irq, ds1wm_data);
 err1:
 	iounmap(ds1wm_data->map);
-- 
1.5.6.5


  reply	other threads:[~2009-02-06 16:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 16:53 [PATCH 0/6] fix PASIC3/DS1WM, use MFD core Philipp Zabel
2009-02-05 16:53 ` [PATCH 1/6] mfd: DS1WM: convert to " Philipp Zabel
2009-02-05 16:53 ` [PATCH 2/6] mfd: PASIC3: " Philipp Zabel
2009-02-05 16:53 ` [PATCH 3/6] pxa/magician: remove deprecated .bus_shift from PASIC3 platform_data Philipp Zabel
2009-02-05 16:53 ` [PATCH 4/6] mfd: PASIC3: remove unused bus_shift field Philipp Zabel
2009-02-05 16:53 ` [PATCH 5/6] mfd: DS1WM: remove clock handling Philipp Zabel
2009-02-06 16:31   ` Philipp Zabel [this message]
2009-02-05 16:53 ` [PATCH 6/6] mfd: PASIC3: supply clock_rate to DS1WM via driver_data Philipp Zabel
2009-02-05 21:14 ` [PATCH 0/6] fix PASIC3/DS1WM, use MFD core Evgeniy Polyakov
2009-02-06 14:16 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233937900-18710-1-git-send-email-philipp.zabel@gmail.com \
    --to=philipp.zabel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome