mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: x86 maintainers <x86@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64} builds
Date: Wed, 11 Feb 2009 17:11:38 +0000	[thread overview]
Message-ID: <1234372298.3586.23.camel@macbook.infradead.org> (raw)

It is a steaming great pain in the arse when the value of CONFIG_64BIT
explicitly written in my .config file is overridden by the value of
$ARCH inferred from the environment.

If I have a 32-bit .config and I happen to build it without remembering
to put 'ARCH=i386' on the make command line, it shouldn't force
CONFIG_64BIT=y and reconfigure.

This patch should fix that, while still allowing defconfig to work as it
currently does for both 32-bit and 64-bit environments, and still giving
the default value of CONFIG_64BIT according to $ARCH. It's just that it
won't _force_ a change to CONFIG_64BIT when it's set to something other
than what $ARCH would imply.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 73f7fe8..516046d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -3,7 +3,7 @@ mainmenu "Linux Kernel Configuration for x86"
 
 # Select 32 or 64 bit
 config 64BIT
-	bool "64-bit kernel" if ARCH = "x86"
+	bool "64-bit kernel"
 	default ARCH = "x86_64"
 	help
 	  Say yes to build a 64-bit kernel - formerly known as x86_64

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


             reply	other threads:[~2009-02-11 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 17:11 David Woodhouse [this message]
2009-02-11 17:22 ` Ingo Molnar
2009-02-12  7:26   ` Ingo Molnar
2009-02-12  8:36     ` David Woodhouse
2009-02-12 20:09       ` H. Peter Anvin
2009-02-13 11:12         ` Ingo Molnar
2009-06-30 11:10     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234372298.3586.23.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome